Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixes spacing issue that cut budget table out of gsod proposal doc #1505

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

HCloward
Copy link
Contributor

What/Why/How?

There was a space addd to the closing Markdoc bracket that kept the final budget table from showing up on the gsod proposal page. This PR is to fix that spacing issue.

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@HCloward HCloward self-assigned this Mar 25, 2024
@HCloward HCloward requested a review from a team as a code owner March 25, 2024 18:09
Copy link

changeset-bot bot commented Mar 25, 2024

⚠️ No Changeset found

Latest commit: 0b1343a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 25, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 984.6 ± 16.6 963.3 1009.8 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 999.5 ± 18.7 970.6 1042.8 1.02 ± 0.03

Copy link
Contributor

github-actions bot commented Mar 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.64% 4394/5733
🟡 Branches 66.72% 2360/3537
🟡 Functions 70.1% 722/1030
🟡 Lines 76.82% 4125/5370

Test suite run success

716 tests passing in 101 suites.

Report generated by 🧪jest coverage report action from 0b1343a

@HCloward HCloward added gsod and removed Type: Docs labels Mar 25, 2024
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed this the first time! Approved.

@HCloward HCloward merged commit 652a4b2 into main Mar 25, 2024
34 checks passed
@HCloward HCloward deleted the docs/fix-gsod-prop branch March 25, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants