-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add markdown output format for lint command #1559
Conversation
🦋 Changeset detectedLatest commit: 39b8eac The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Test suite run success735 tests passing in 102 suites. Report generated by 🧪jest coverage report action from 39b8eac |
Other changes that I think we should consider for this feature:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Co-authored-by: Heather Cloward <heathercloward@gmail.com>
37c5c16
to
3b7f007
Compare
What/Why/How?
Related to #1539, add markdown format output to the lint command, similar to what we have for stats. This could be used in a lint status report, a github job summary, or anywhere else where a renderable format is useful.
Testing
Caution: PR doesn't include tests yet, I'd like to get some feedback on the feature.
Screenshots (optional)
Markdown output example:
validating /home/lorna/temp/datasette.yaml...
Lint: ../../temp/datasette.yaml
license
field./home/lorna/temp/datasette.yaml: validated in 11ms
❌ Validation failed with 1 error and 1 warning.
run
redocly lint --generate-ignore-file
to add all problems to the ignore file.Check yourself
Security