Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace ➡️ with 🔀 to align the words #1595

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

arkbriar
Copy link
Contributor

@arkbriar arkbriar commented Jun 19, 2024

What/Why/How?

The ➡️ should be the same width as other emojis normally though it shows differently in GitHub's code viewer (➡️). Currently, the additional space makes the stats subcommand print such outputs, which is weird

image

The PR fixes it by removing the space.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Signed-off-by: arkbriar <arkbriar@gmail.com>
@arkbriar arkbriar requested review from a team as code owners June 19, 2024 15:43
Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: 177ac82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr tatomyr requested a review from lornajane June 19, 2024 19:23
@tatomyr
Copy link
Contributor

tatomyr commented Jun 20, 2024

Hi @arkbriar! Could you replace the ➡️ emoji with 🔀? I think it should eliminate the original issue with improper alignment:
image

Signed-off-by: arkbriar <arkbriar@gmail.com>
@arkbriar arkbriar changed the title remove unexpected extra space before ➡️ Path Items chore: replace ➡️ with 🔀 to align the words Jun 21, 2024
Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arkbriar ! This looks much better in all output formats

@lornajane lornajane merged commit 9456460 into Redocly:main Jun 21, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants