Adding TaskManager, Fixing player-data reset & scoreboard issue #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedstoneFuture
changed the title
RedstoneFuture
changed the title
RedstoneFuture
changed the title
RedstoneFuture
commented
Jul 3, 2023
missilewars-plugin/src/main/java/de/butzlabben/missilewars/game/Game.java
Show resolved
Hide resolved
RedstoneFuture
commented
Jul 3, 2023
missilewars-plugin/src/main/java/de/butzlabben/missilewars/game/Game.java
Show resolved
Hide resolved
RedstoneFuture
commented
Jul 3, 2023
missilewars-plugin/src/main/java/de/butzlabben/missilewars/game/misc/ScoreboardManager.java
Show resolved
Hide resolved
daniel-naegele
suggested changes
Jul 18, 2023
missilewars-plugin/src/main/java/de/butzlabben/missilewars/game/timer/TaskManager.java
Outdated
Show resolved
Hide resolved
missilewars-plugin/src/main/java/de/butzlabben/missilewars/game/Game.java
Show resolved
Hide resolved
daniel-naegele
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
Games.javais the central object for a game. However, some methods and fields can be outsourced to manager classes to keep the Games class a bit more manageable. The following is a suggestion for outsourcing:Games.java
Moving from
Game.javatoTaskManager.javaWith this investigation, a runtime issue was also found and fixed that did not correctly reset the player datas after the
GameState.ENDphase, because the EventListeners were already disabled. In addition, the game duration (currently for the scoreboard) was cached for theGameState.ENDphase.