Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows unexpected exceptions in multi-page applications. #146

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paoldev
Copy link
Contributor

@paoldev paoldev commented Nov 12, 2023

Fixes #141 for Windows.
Edit: also fixes #159

This PR

  • makes cameraPreview unloading phase more robust, mainly for multi-page, Shell-based applications
  • tries to automatically restart the camera feed when returning to the page containing the unloaded cameraPreview control, in multi-page, Shell-based applications

All these commits are needed to address issue #141 for Windows.

A multi-page BigIslandBarcode test application can be found at https://github.com/paoldev/ZXing.Net.Maui/tree/AppShell, where "MainPage" and "Page 2" contain a camera control, whereas "Page 1" is just an empty page.

@paoldev
Copy link
Contributor Author

paoldev commented Nov 12, 2023

CI build errors seem to be related to SkiaSharp dependency for net7.0-maccatalyst, which is unrelated to this PR code.

@paoldev
Copy link
Contributor Author

paoldev commented Jan 15, 2024

According to comments in #159, this PR also seems to fix issues described there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant