Fixed the problem with barcode rendering upside down on macOS #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
pushed a commit
to nblockchain/ZXing.Net.Xamarin
that referenced
this pull request
Feb 25, 2019
Upstream PR: Redth#802
|
@mierzynskim why is the Info.plist changed here? |
|
@knocte I just couldn't run the sample on |
|
@mierzynskim ah I see, do you mind separating this in 2 commits then? |
mierzynskim
force-pushed
the
macOSbarcodeFix
branch
from
7fb7f06
to
1d1a1d9
Compare
knocte
pushed a commit
to nblockchain/ZXing.Net.Xamarin
that referenced
this pull request
Feb 25, 2019
Upstream PR: Redth#802
|
Thanks Michal! @Redth FYI I tested this bugfix and it works like a charm. |
Merged
|
Thanks for your contribution! I've done a lot of work to modernize the ZXing.Net.Mobile code base and have merged those changes into master. I've included fixes from your PR manually. Please open a new issue or PR if you have more suggestions or changes. Thank you so much for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that barcodes are rendered upside down on macOS.
It looks like the author of the macOS solution didn't notice that Core Graphics has a different coordinate system than UIKit https://developer.apple.com/library/archive/documentation/General/Conceptual/Devpedia-CocoaApp/CoordinateSystem.html