Fix scanning not running when calling StartScanning #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone calls StartScanning before the OnCreateView lifecycle method is finished doing its thing setting up the Surface etc. Then the callback they pass in StartScanning, never gets triggered. This fixes the issue, by assuming that in case of someone calling StartScanning before OnCreateView, then `scanCallback` is set. In such case just call StartScanning again to acutally start scanning and the Scan() method is invoked.
Redth
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone calls
StartScanningbefore theOnCreateViewlifecycle methodis finished doing its thing setting up the Surface etc. Then the callback they pass in StartScanning, never gets triggered.This fixes this issue, by assuming that in case of someone calling
StartScanningbeforeOnCreateView, thenscanCallbackis set. In such case just callStartScanningagain to acutally start scanning and theScan()method is invoked and everyone is happy.I don't believe this is a breaking change. Since
StartScanningwill only get triggered inOnCreateViewif the dev already tried calling it prematurely.Fixes #934