Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change dependencies from dev for issue #3 #4

Merged
merged 2 commits into from
Mar 22, 2021
Merged

fix: change dependencies from dev for issue #3 #4

merged 2 commits into from
Mar 22, 2021

Conversation

ReeceM
Copy link
Owner

@ReeceM ReeceM commented Mar 22, 2021

This PR is to fix the issue of the incorrect dependencies in the package.json file

Moved both sitemap and prismic-javascript to main dependencies entry

@ReeceM
Copy link
Owner Author

ReeceM commented Mar 22, 2021

note to self: Next.js 10.0.9 uses a different nextServer constructor

10.0.7 works, server constructor type is different, the returned server too.

Need to fix...

@ReeceM
Copy link
Owner Author

ReeceM commented Mar 22, 2021

Right, so the code given from apollo was adding the server twice... version 10.0.7 thats alright, 10.0.9 is a no go for that.

@ReeceM ReeceM linked an issue Mar 22, 2021 that may be closed by this pull request
Libraries that are listed as Dev Dependencies should be Dependencies #3
Closed
@ReeceM ReeceM merged commit 8dd2cb0 into main Mar 22, 2021
@ReeceM ReeceM deleted the fix/correct-library-dependencies branch March 22, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Libraries that are listed as Dev Dependencies should be Dependencies
1 participant
@ReeceM