-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle and document corner cases of lwork in lapack #942
handle and document corner cases of lwork in lapack #942
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #942 +/- ##
========================================
Coverage 0.00% 0.00%
========================================
Files 1930 1930
Lines 190055 190413 +358
========================================
- Misses 190055 190413 +358 ☔ View full report in Codecov by Sentry. |
e5f392a
to
364901d
Compare
Extension to all precisions for this scope of functions is in progress. |
69ef653
to
0f5cc87
Compare
2c6e5c7
to
f15520d
Compare
8cba9e5
to
e1ffdc0
Compare
PR is ready! @langou please review one more time. I think, several changes should be pointed out in addition to already mentioned issues.
One can see, that important functions of generation/application of Also, thanks to @kleineLi for the help with complex precisions and intermediate review. |
e1ffdc0
to
280e161
Compare
Handle and document corner cases of lwork in lapack
This PR contains fixes related to the following issues:
Actually, for many functions in LAPACK these issues are already solved or did not exist at all. This PR handles remaining ones for general, symmetric and generalized problems (double precision only at the moment). Please review. If there are some questions, let's discuss!