Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the NAG Fortran compiler #951

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

ACSimon33
Copy link
Contributor

Description

There were several issues with using the NAG Fortran compiler in the new release:

  • usage of non-standard IMAG function. I replaced it with AIMAG.
  • missing check_fortran_compiler_flag macro include
  • propagation of Fortran flags to the CBLAS subdirectory
  • missing comma in FORMAT expression in the test framework

Checklist

  • [n/a] The documentation has been updated.
  • [n/a] If the PR solves a specific issue, it is set to be closed on merge.

@ACSimon33 ACSimon33 changed the title Nagfor_imag_fix Fixes for the NAG Fortran compiler Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cbb5536) 0.00% compared to head (2a0aea9) 0.00%.
Report is 1 commits behind head on master.

Files Patch % Lines
SRC/claqp2rk.f 0.00% 2 Missing ⚠️
SRC/claqp3rk.f 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #951   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1930     1930           
  Lines      190055   190055           
=======================================
  Misses     190055   190055           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@langou langou merged commit 9560fe2 into Reference-LAPACK:master Nov 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants