Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can steal Mudraptor Eggs from nests and this completes nest mission objectives. They also float without weight #10968

Closed
1 of 2 tasks
Wheatley1002 opened this issue Jan 19, 2023 · 6 comments
Assignees
Labels
Bug Something isn't working Code Programming task Design Design-related task

Comments

@Wheatley1002
Copy link

Wheatley1002 commented Jan 19, 2023

Disclaimers

  • I have searched the issue tracker to check if the issue has already been reported.
  • My issue happened while using mods.

What happened?

Key Information

Game mode: Campaign
Game type: Multiplayer
Campaign save version: Started in 100.13.0.0, issue occurred in version 100.13.0.0
Server type: Steam P2P

Issue Report

During nest missions, players can interact with Mudraptor Eggs. This will show the inventory of the egg for a brief moment before the inventory closes and the player grabs the egg. If the player drops the egg, it will float where it was last dropped. Finally, if the player takes all of the eggs out of the cave, the nest objective will be considered complete. We didn't even make it out of the cave before the objective cleared.

image
Figure 1. Floating Mudraptor Eggs.

image
Figure 2. Mudraptor Eggs stolen from nest on friendly submarine.

image
Figure 3. Mission menu showing completed Mudraptor nest mission.

Reproduction steps

  1. Start a campaign save (or mission mode; I haven't tested this however) and pick a nest mission
  2. Make sure the nest is a Mudraptor nest
  3. Enter the nest and left click the Mudraptor Egg
  4. Observe how you can pick it up
  5. Move away from the wall or floor and drop the egg
  6. Observe how it doesn't move and floats where you left it
  7. Pick the egg back up and start leaving the cave
  8. Observe how (if all other eggs are stolen or destroyed) this completes the mission objective

Bug prevalence

Happens regularly

Version

Faction/endgame test branch

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

No response

@Regalis11 Regalis11 changed the title [Factions] You can steal Mudraptor Eggs from nests and this completes nest mission objectives. They also float without weight You can steal Mudraptor Eggs from nests and this completes nest mission objectives. They also float without weight Jan 19, 2023
@itchyOwl
Copy link
Collaborator

itchyOwl commented Jan 19, 2023

Note: egg densities were adjusted in the item density pass. So if these need further adjustments, do it there.

@Regalis11 Regalis11 added Bug Something isn't working Code Programming task Design Design-related task labels Jan 19, 2023
@BiffW
Copy link

BiffW commented Jan 19, 2023

Egg stealing is unexpected but interesting. Me and my friends had fun taking eggs from abandoned outposts for deconstruction or fabricating petraptor eggs. Is there any chance of keeping it as a feature?

@Regalis11
Copy link
Collaborator

I agree that stealing them (and selling them for profit, deconstructing them or turning them into pet raptor eggs) is an interesting unintentional side-effect that we should probably keep. But we need to take that into account in the nest mission logic, which disables their physics when attaching them to the cave.

@Regalis11
Copy link
Collaborator

Actually it seems the issue wasn't how the physics are disabled: this had already been taken into account by reactivating the physics when the item is picked up. The problem was the eggs were using the default (neutrally buoyant) density, which seems to have been addressed as a part of an item density fix pass that we did recently (not included in any public build yet).

@Regalis11
Copy link
Collaborator

Actually we decided to make the large eggs non-pickable again: being able to loot them caused too many problems, messing up the reward balance of the missions and allowing exploits by doing an abandoned outpost mission and repeatedly looting the eggs. https://github.com/Regalis11/Barotrauma-development/commit/ed6d9800f0dbca432fdec347163f606fe90dfbd7

@Rokvach
Copy link
Collaborator

Rokvach commented Jan 24, 2023

Tested, working correctly. Closing.

@Rokvach Rokvach closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task Design Design-related task
Projects
None yet
Development

No branches or pull requests

5 participants