Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed The Game Not using courbd #257

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

theOneTrueFunniBoi
Copy link

Fixes the game using Courier New Regular in situations that are meant to use Courier New Bold.

@theOneTrueFunniBoi
Copy link
Author

Pictures:
image
image
image

Copy link
Owner

@Regalis11 Regalis11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The motivation behind these changes isn't clear to me. Why's the game "meant to use" Courier New Bold instead of Courier New Regular in these cases?

@theOneTrueFunniBoi
Copy link
Author

theOneTrueFunniBoi commented Jan 29, 2024

The motivation behind these changes isn't clear to me. Why's the game "meant to use" Courier New Bold instead of Courier New Regular in these cases?

The main issue here is that due to a bug (referenced in a code comment), the b3d engine only properly loads fonts if the font file's name is the same as the fonts name (ex: cour/Courier New.ttf would work, but cour/cour.ttf would not). The problem is that the "Courier New Bold.ttf" font is named "Courier New.ttf" by mistake, so the engine just uses regular Courier New. This pull request simply fixes the issue by adjusting the font file name and the code to reflect the adjustment. I hope this gives you the info you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants