Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable C# 8 Nullable Reference Types #307

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Enable C# 8 Nullable Reference Types #307

merged 1 commit into from
Mar 12, 2021

Conversation

RehanSaeed
Copy link
Owner

@RehanSaeed RehanSaeed commented Mar 10, 2021 •
edited
Loading

Fixes #175

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning. labels Mar 10, 2021
@RehanSaeed RehanSaeed requested a review from krajek March 10, 2021 10:26
@RehanSaeed RehanSaeed force-pushed the enable-nullable-reference-types branch from c555a9c to 82dcaec Compare March 10, 2021 10:36
@RehanSaeed
Copy link
Owner Author

This needs some testing to make sure all is well.

@RehanSaeed RehanSaeed mentioned this pull request Mar 10, 2021
Closed
krajek
krajek reviewed Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@krajek krajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, almost everything is nullable apart from incoming exception to be destructured, properties bag, and a string key in a dictionary. Nice improvement

Tests/Serilog.Exceptions.Test/Destructurers/ReflectionBasedDestructurerTest.cs Show resolved Hide resolved
Tools/ExceptionFinderTool/Program.cs Show resolved Hide resolved
Tests/Serilog.Exceptions.Test/Filters/CompositeExceptionPropertyFilterTest.cs Outdated Show resolved Hide resolved
@RehanSaeed RehanSaeed force-pushed the enable-nullable-reference-types branch from 82dcaec to 58c6f72 Compare March 11, 2021 13:46
@RehanSaeed
Copy link
Owner Author

@krajek Are we good to go?

@krajek
Copy link
Collaborator

krajek commented Mar 11, 2021

I have no more issues with the code, thanks for the work you put into it.

@RehanSaeed RehanSaeed merged commit 2945cee into main Mar 12, 2021
@RehanSaeed RehanSaeed deleted the enable-nullable-reference-types branch March 12, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krajek krajek krajek left review comments

Assignees
No one assigned
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. minor Pull requests requiring a minor version update according to semantic versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add C# 8 Nullable Reference Types
2 participants
@RehanSaeed @krajek