Fix property metadata retrieval in case of redefined properties #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RehanSaeed
reviewed
May 24, 2021
Tests/Serilog.Exceptions.Test/Reflection/ReflectionInfoExtractorTest.cs
Outdated
Show resolved
Hide resolved
RehanSaeed
reviewed
May 24, 2021
RehanSaeed
reviewed
May 24, 2021
RehanSaeed
reviewed
May 24, 2021
…-metadata-retrieval
|
@RehanSaeed I consider the current version ready for a real review. |
|
@RehanSaeed are you available for review and merge? |
RehanSaeed
reviewed
Jun 8, 2021
RehanSaeed
reviewed
Jun 8, 2021
|
Ok, I have addressed one of your suggestions in the latest commit, others in the comments. LGTM! :-) |
|
LGTM |
RehanSaeed
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft for now, for early review for myself mainly.
Only to be considered for merge after #344 is merged.
I have extracted
ReflectionInfoExtractorclass to separate logic regarding reflection information from restructuring logic inReflectionBasedDestructurer. Apart from obviously makingReflectionBasedDestructurercode slimmer, it allowed for very focused unit tests of the new class.