Add BinaryBuilder build_tarballs.jl script #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying out lots of different options for how to build/host/distribute binaries, i'm proposing we just use BinaryBuilder.jl and do so in the way it's intended to be used... except hosting the build_tarballs.jl script here (instead of in Yggdrasil) and the resulting package in an RAI GitHub org (instead of in JuliaBinaryWrappers org)
The means we can use BinaryBuilder.jl to build binaries, create a JLL Julia package for distributing them, and handle uploading both the package and binaries to a GitHub repo. And that we are free to make releases without going via Yggrasil and needing a PR approval their. The downside is that Yggdrasil CI won't build the binaries for us (for now we can just build locally and later figure out a nicer CI-base setup if necessary). And the JLL package is outside this repo (because BinaryBuilder isn't really set up for the JLL and binaries to be anywhere other than in their own repo).