Initialize basic tests #2
Conversation
Drvi
commented
Dec 12, 2023
Drvi
commented
- Set up CI
- Simplify FFI a bit
| container::Cstring | ||
| key::Cstring | ||
| host::Cstring | ||
| end |
There was a problem hiding this comment.
can you say why this is preferable to the existing code?
It looks more complex to me.
There was a problem hiding this comment.
Instead of manually casting struct between two types, we rely on the Julia machinery that is supposed to solve this problem: the cconvert that transforms the data into C-compatible types and followed by the unsafe_convert which can then safely create pointers from the whatever it was given by cconvert. Those two are automatically called by @ccall .
There was a problem hiding this comment.
I think this is how you are supposed to do this thing, because it handles lifetimes for you and is applicable to all @ccalls we'll do for list, head and others.
There was a problem hiding this comment.
But if you are really against it, I'll remove it
| @@ -0,0 +1,45 @@ | |||
| name: CompatHelper | |||
There was a problem hiding this comment.
is this worth having even if we have no deps?
There was a problem hiding this comment.
I just copied everything over, I thought it might be useful eventually, but can remove it if you want to
|
I'll merge it now, but I'm happy to make adjustments later |
