change memory parameters to signed integers to prevent signed to unsi… #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
port-to-v1.10
d-netto
removed
the
port-to-master
kpamnany
approved these changes
Jul 11, 2024
d-netto
force-pushed
the
dcn-no-signed-to-unsigned-comparison
branch
from
632d320
to
baaaee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
There are a bunch of places (i.e. here) where
max_total_memory(previously unsigned) is compared tolive_bytes.This is problematic because it will lead to overflow in the comparison if
live_bytesis negative (which should never happen, but we've seen in a few engines...)Checklist
Requirements for merging:
port-to-*labels that don't apply.