-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly handle CellRenderCombo returning integers #940
Conversation
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.08%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To properly handle the integer data type returned from CellRendererCombo's when they display string type information.
Describe how this was implemented.
Created lists containing the pick list strings for the CellRendererCombo. The returned integer value then represents the index in the list which can be used to select the proper text to display.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Closes #820
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
decorating the code block. These # ISSUE: comments are automatically
converted to issues on successful merge. Alternatively, you can manually
raise an issue for each problem area you identify.