Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical view selectable for all categories #165

Closed
PhieF opened this issue Apr 1, 2017 · 14 comments
Closed

Graphical view selectable for all categories #165

PhieF opened this issue Apr 1, 2017 · 14 comments
Assignees
Milestone

Comments

@PhieF
Copy link

PhieF commented Apr 1, 2017

Hi,

I've just improved the artist view, here is the result
http://pix.toile-libre.org/upload/original/1491067626.png

so after selecting an artist, I now have a view with albums only from this artist

Here are the two files I've modified
http://phoenamandre.fr/shared/audioplayerimprovement.tar.gz
Just sharing in case you'd like to merge it

Thanks for your great app !

@Rello
Copy link
Owner

Rello commented Apr 2, 2017

Hello @Phoenamandre
thank you for your suggestion.
what you are trying is to get a filter on the artist and show this in the layout of the "albums view".

The categories on the dropdown are on purpose without any graphical output because we have users with 10.000s of titles and they depend on a list-view.
So in this case, the views can not be mixed.

What you want to have would be a filter within the existing "Albums" because there we remain purely within the graphical display

We will keep it in the backlog, but at the moment it is not the main focus because we want to extend features like flac or streams due to frequent requests.

thank you again for your input

@Rello Rello changed the title Improvement on artist view Graphical artist view Apr 2, 2017
@Rello Rello closed this as completed Apr 2, 2017
@Rello
Copy link
Owner

Rello commented Apr 2, 2017

one remark for your code suggestion:

$SQL .=" AND id in (SELECT album_id from *PREFIX*audioplayer_tracks WHERE artist_id = ".$artist_id.")";

  • the "id" needs to be properly described for DB compatibility ('AA'.'id')
  • don´t concatenate variable values into a SQL-string for injection risks. always use the "?" and parse it via $result = $stmt->execute(array($this->userId, $artist_id))

@PhieF
Copy link
Author

PhieF commented Apr 3, 2017

Thanks for the tip !
Indeed, flac would be a great improvement !

@PhieF
Copy link
Author

PhieF commented Apr 4, 2017

I've just added that to fasten songs loading with the album view by artist, sharing it for those who would like to use it

public function loadSongs(){
    $artist_id = $this->params('artist_id');

        //		$SQL="SELECT  `AT`.`id`,`AT`.`title`,`AT`.`number`,`AT`.`album_id`,`AT`.`artist_id`,`AT`.`length`,`AT`.`file_id`,`AT`.`bitrate`,`AT`.`mimetype`,`AA`.`name` AS `artistname` FROM `*PREFIX*audioplayer_tracks` `AT`
		$SQL="SELECT  `AT`.`id`,`AT`.`title`,`AT`.`number`,`AT`.`album_id`,`AT`.`length`,`AT`.`file_id`,`AT`.`mimetype`,`AA`.`name` AS `artistname` FROM `*PREFIX*audioplayer_tracks` `AT`
						LEFT JOIN `*PREFIX*audioplayer_artists` `AA` ON `AT`.`artist_id` = `AA`.`id`
			 			WHERE  `AT`.`user_id` = ?";
	    //to add			
		if(!empty($artist_id)){
			$SQL .="AND artist_id = ? ";
		}
		$SQL.="ORDER BY `AT`.`album_id` ASC,`AT`.`number` ASC";
		
		...
		
		if(!empty($artist_id))
			$result = $stmt->execute(array($this->userId,$artist_id));
		else
			$result = $stmt->execute(array($this->userId));
		

@WhiteBahamut
Copy link

Actually this would be one of the main changes for me. I really like the app (it just works! :) ). But I am used to group the graphical view by artist with all the albums/titles grouped to the artist. And not group by album (as it is right now).
So it would be nice to be able to change the graphical view to either Artists or Albums.

@Rello
Copy link
Owner

Rello commented Jul 27, 2019

Hello,
thank you for your inquiry. this feature is already on the backlog.
#39

actuall, the background coding is undergoing a major redesign and modularization at the moment.
the plan ist to enable a list & graphical view for several categories. similar to the files app, where the display can be triggered.

just hold on a little...

@Rello
Copy link
Owner

Rello commented Jul 27, 2019

@WhiteBahamut
I want to come back to your question: do you want to sort the Albums-View differently (currently alphabetic on album name)? only a diffent sorting?

or you want to use the category drilldown at the left and select an artist - and then only see the albums (grafical) for this artist?

@WhiteBahamut
Copy link

I would love to have an Album view which will show
a) an artist image
b) or a thumbnail of the albums for this artits

Like http://cdn.arstechnica.net/wp-content/uploads/2015/07/music-artists-980x592.png

@Rello
Copy link
Owner

Rello commented Jul 29, 2019

Hello,
i am preparing a kind of "filtered album view".
so if you select a Genre or an artist, all albums in this category will be shown - so a partial amount of the total albums view.

An artist-image is not possible because thats not part of ID3, so it can not be extracted from your metadata.

@WhiteBahamut
Copy link

ahh true.. totally forgot. A good alternative would be something like

A
ABBA AC/DC
B
Beatles Blondie
...
W
White Stripes WithinTtemptation

For me, the grouping is the important part. And to have a more prominent Artist view.

@Rello Rello self-assigned this Jul 30, 2019
@Rello Rello added this to the 2.8.0 milestone Jul 30, 2019
@Rello Rello changed the title Graphical artist view Graphical view selectable for all categories Jul 30, 2019
@Rello Rello reopened this Aug 1, 2019
@Rello
Copy link
Owner

Rello commented Aug 1, 2019

fyi: work in progress for next release...

Rello added a commit that referenced this issue Aug 3, 2019
- store navigation status;
- cleanup & speedup
Rello added a commit that referenced this issue Aug 4, 2019
- handles presets from previous AP versions
- further function renamings
@Rello
Copy link
Owner

Rello commented Aug 22, 2019

@PhieF @WhiteBahamut
do you have an NC setup where you could test the current AP beta version?
we made a HUGE step forward. Cover-View for all + big UI speedup

would like to hear some feedback if possible...

@WhiteBahamut
Copy link

I could setup a basic env in a vm to make a very basic review

@Rello Rello removed the in progress label Aug 31, 2019
@Rello Rello closed this as completed Aug 31, 2019
@WhiteBahamut
Copy link

Sorry for my late response. The new version runs smoother on my setup. The cover view works also good if I switch to Album Artist view.
Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants