Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLAC Support #45

Closed
microcreators opened this issue Aug 25, 2016 · 7 comments
Closed

FLAC Support #45

microcreators opened this issue Aug 25, 2016 · 7 comments
Assignees
@Rello
Labels
enhancement
Milestone
2.0.0

Comments

@microcreators
Copy link

microcreators commented Aug 25, 2016 •
edited
Loading

first of all, thank you very much for 1.1 - works great 👍
and my small request is simple... flac support. although I'm not really sure how much you're dependant on this external players.

one more thing. i noticed users have to refresh the list of albums, although it's all based on same, shared directories. any chance to have a an admin to refresh the list for everyone?
thanks!
@ghost
Copy link

ghost commented Aug 25, 2016 •
edited by ghost
Loading

FLAC support is on the to-do list since the project start.
Please be patient, but this takes a while.

Please, don't mix up more than one bug or request in one issue. Thanks.

@Rello Rello mentioned this issue Aug 27, 2016
Closed
15 tasks
@Rello
Copy link
Owner

Rello commented Oct 16, 2016

followup in Roadmap
will be reopened when work is started

@Rello Rello closed this as completed Oct 16, 2016
@ghost ghost added the low priority label Nov 18, 2016
@microcreators
Copy link
Author

Just to add to it... It sounds like the upcoming Chrome 56 would support FLAC streaming out of the box. Same for FF 51 (although I may be wrong here).

@SharkyRawr
Copy link

FLAC support has landed in Fx and Chrome. Knowing nothing about the internal workings of this project, could it now be as easy as adding the FLAC mime-type and/or extension to the list of supported formats?

@ghost ghost changed the title [request] flac support Feature: FLAC Support Feb 5, 2017
@Rello
Copy link
Owner

Rello commented Feb 5, 2017

Hello,
thank you for the heads-up.
we are following @scottschiller on this topic already and it seem promising to have something in the near future.
But its not only about the player - we need to tweak the scanner a little in regards to the big file sizes on external storage.

Keep on watching here

@ghost ghost changed the title Feature: FLAC Support FLAC Support Feb 12, 2017
@Rello
Copy link
Owner

Rello commented Feb 22, 2017

scottschiller/SoundManager2#148

@ghost ghost removed the low priority label Mar 27, 2017
@Rello Rello reopened this Apr 6, 2017
@Rello Rello self-assigned this Apr 6, 2017
@ghost ghost added this to the 1.6.0 milestone Apr 6, 2017
Rello added a commit that referenced this issue Apr 9, 2017
@Rello
activate flac mimetype in scanner
8c80d3c 
#45
Rello added a commit that referenced this issue Apr 9, 2017
@Rello
patch soundmanger2 for flac
b8025f1 
#45
Rello added a commit that referenced this issue Apr 9, 2017
@Rello
patch soundmanger2 for flac
d260352 
#45
@Rello
Copy link
Owner

Rello commented Apr 9, 2017 •
edited
Loading

Hello,

the FLAC mime type is being integrated into Audio Player.
Attention: flac is only supported on latest Chrome & FF at the moment.

  • locally patch soundmanager2 due to missing update
  • Include in scanner
  • Include in files app (one click play & share player)
  • playlists depending on browser capabilities: When a browser is not able to play flac (or one of the others), the track will be marked with a different text formatting and an indicator is shown
  • display browser capabilities in user settings screen
  • create wiki for browser dependencies
    https://github.com/rello/audioplayer/wiki/audio-files-and-mime-types#browser-support

Rello added a commit that referenced this issue Apr 11, 2017
@Rello
activate flac in sharing screen
7771f53 
#45
Rello added a commit that referenced this issue Apr 11, 2017
@Rello
mimetype browser canPlay check
7dd2b9f 
in case a mimetype is not supported by the browser (e.g. FLAC in Safari), the title will be shown in italic font and a notification icon is shown.

Also, the edit-pen is replaced with the "..." similar to files app

#45
Rello added a commit that referenced this issue Apr 16, 2017
@Rello
transfer mime type in list views
e6ea303 
#45
@Rello Rello added testing and removed in progress labels Apr 16, 2017
Rello added a commit that referenced this issue Apr 17, 2017
@Rello
mimetype-check in user settings - user.php
a32a812 
#45
Rello added a commit that referenced this issue Apr 17, 2017
@Rello
mimetype-check in user settings - template
8e360e8 
#45
Rello added a commit that referenced this issue Apr 17, 2017
@Rello
mimetype-check in user settings - js
814a9f1 
#45
Rello added a commit that referenced this issue Apr 17, 2017
@Rello
support-link for mime-types
1d8a35a 
#45
@ghost ghost removed the pending release label May 24, 2017
@ghost ghost closed this as completed May 24, 2017
@ghost ghost mentioned this issue May 24, 2017
Closed
1 task
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rello Rello

Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@SharkyRawr @microcreators @Rello