Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Changes [issues/32/33/31] #34

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Multiple Changes [issues/32/33/31] #34

merged 1 commit into from
Oct 5, 2020

Conversation

vijayakshit
Copy link
Contributor

This was referenced Oct 4, 2020
Open
Closed
@vijayakshit
Copy link
Contributor Author

Solves #33
Solves #32

@vijayakshit
Copy link
Contributor Author

vijayakshit commented Oct 4, 2020 •
edited
Loading

@Remeic The changes were intersecting hence the single PR for all 3 issues.

@Remeic Remeic linked an issue Oct 4, 2020 that may be closed by this pull request
Add more temp email services #32
Closed
@Remeic
Copy link
Owner

Remeic commented Oct 4, 2020

Hi @vijayakshit, test seems broken due to component refactor, can check it out?

@Remeic Remeic mentioned this pull request Oct 4, 2020
Open
@vijayakshit
Copy link
Contributor Author

@Remeic Fixed the problem with failing tests and also corrected Some typos from last commit.

@vijayakshit
Copy link
Contributor Author

Fixed some incorrect variable references introduced with the last commit.

@vijayakshit
Multiple Changes
aa09351 
* Added Support for multiple Email Services(Yopmail, Dispostable).[Remeic#32]
* Added Button For Direct Mailbox access.[Remeic#33]
* Isolated Config from components.
* Introduced Goober for styling[Some help with Remeic#31]
* Refactored Code into Smaller Components.

Corrected Failing Tests,Corrected Typos
* Updated Tests.
* Made Mail Generator Container a Class Component.
* Corrected filename Typos
@vijayakshit
Copy link
Contributor Author

@Remeic Squashed the fix commits as well.

@Remeic Remeic merged commit 09efbf9 into Remeic:master Oct 5, 2020
@vijayakshit
Copy link
Contributor Author

@Remeic This PR also Solves #33

Also This shows as Ineligible Repository for hactoberfest.

Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers of the repository can add the "hacktoberfest" topic to their repository if they wish to participate. Alternatively, an individual PR can be opted-in with a maintainer adding the "hacktoberfest-accepted" label to the PR.

@Remeic
Copy link
Owner

Remeic commented Oct 6, 2020

@vijayakshit Sorry me, i forget to set the topic, say me if hacktoberfest count yours PR now

@vijayakshit
Copy link
Contributor Author

Yes it shows! Thank you @Remeic for accepting my contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more temp email services
2 participants
@vijayakshit @Remeic