Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: improve dependency lookup when loading module library. #179

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bruvzg
Copy link

@bruvzg bruvzg commented Oct 14, 2023

Fixes loading of the module library dependencies when OIDN main library is dynamically loaded at runtime, and libraries are not in the executable directory.

e.g., when app dynamically load OpenImageDenoise.dll at runtime, using absolute path, ModuleLoader attempts to load OpenImageDenoise_device_cpu.dll module, but it fails since tbb12.dll is not in the library search path. This change temporary adds the module library directory to the search path to ensure dependencies are loaded correctly.

@Calinou
Copy link

Calinou commented Jun 18, 2024

Bump 🙂 Any interest in reviewing this? This would make it possible for Godot to use OIDN as a library, as opposed to calling its oidnDenoise CLI (which doesn't have a stable interface).

@atafra
Copy link
Collaborator

atafra commented Jun 28, 2024

Sorry, there is interest but so far we had other priorities. We need to look into this carefully because it might have some security implications as well.

@kraszkow
Copy link
Contributor

kraszkow commented Jul 4, 2024

@bruvzg - Could you provide specific details about the problem you're addressing? It would be helpful if you could show the exact location of the DLLs mentioned in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants