Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject payment detectors into the request client. Remove the skipPaymentDetection flag. #1211

Open
Tracked by #1202
MantisClone opened this issue Oct 21, 2023 · 0 comments

Comments

@MantisClone
Copy link
Member

MantisClone commented Oct 21, 2023

Towards #1202

Problem

The payment-detection package is large and takes a long time to download. This is because it includes logic for all payment networks.

Proposed solution

  1. Split the payment detection package by payment network, into separate payment detectors
  2. Make the payment detectors injectable into the request client
  3. Remove the runtime configs like skipPaymentDetection.
@MantisClone MantisClone changed the title Refactor payment detection to be injectable into the request client. Remove the disablepaymentDetection flag. Refactor payment detection to be injectable into the request client. Remove the disablePaymentDetection flag. Oct 21, 2023
@MantisClone MantisClone changed the title Refactor payment detection to be injectable into the request client. Remove the disablePaymentDetection flag. Inject payment detectors into the request client. Remove the disablePaymentDetection flag. Oct 23, 2023
@MantisClone MantisClone changed the title Inject payment detectors into the request client. Remove the disablePaymentDetection flag. Inject payment detectors into the request client. Remove the skipPaymentDetection flag. Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎫 Backlog
Development

No branches or pull requests

2 participants