Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating request from RequestCore will bypass certain validations #39

Closed
kbapuram opened this issue Mar 25, 2018 · 1 comment
Closed

Comments

@kbapuram
Copy link

kbapuram commented Mar 25, 2018

We can create a Request from RequestCore.sol and createRequest function (instead of RequestEthereum.sol). This will bypass some validations such as require(fees == msg.value); .This way we are able to create a request without a mandatory fee

@kbapuram kbapuram changed the title Request is created even if _payees.length != _expectedAmounts.length Creating request from RequestCore will bypass certain validations Mar 25, 2018
@vrolland
Copy link
Contributor

Hello,
As explains in the RequestCore documentation/comments ( see here )

Requests can only be created in the currency contracts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants