Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist for filetypes/paths #317

Closed
msxfm opened this issue Jul 7, 2014 · 3 comments
Closed

Whitelist for filetypes/paths #317

msxfm opened this issue Jul 7, 2014 · 3 comments

Comments

@msxfm
Copy link

msxfm commented Jul 7, 2014

Issue by Dr-Yes
Thursday Jun 21, 2012 at 07:19 GMT
Originally opened as RequestPolicy/requestpolicy#317


I'd like to allow css files to be loaded from 3rd parties. I know this is a bad idea concerning privacy and security so the setting might need a warning.

@msxfm
Copy link
Author

msxfm commented Jul 7, 2014

Comment by ghost
Wednesday Aug 08, 2012 at 14:11 GMT


RequestPolicy/requestpolicy#61 and this one are closely related. If the user could allow whatever file extension to load cross-site, this would fix many usability issues: images, css, swfs/flvs would load properly without any user interaction.

This is not necessarily secure, so there should be a warning when changing this setting. Still, only allowing images from specific/all destinations may be less dangerous than allowing a whole domain just to display images/css.

I always install RP on workstations i build for other people, and they always end up totally disabling it because of these usability issues. This would be a major improvement. @jsamuel what is your view on this?

@nodiscc
Copy link
Contributor

nodiscc commented Dec 5, 2014

So this issue is about supporting rules for file paths. As commented by @Eibwen in #152:

The mimetype of allowed requests can be determined; however, the mimetype of denied requests is a guess at best based on the filename, which may include incorrect extension(s), intermediate extension(s) (eg a cgi), or even no extension at all.

Detecting the real mimetype of a blocked file is not possible (see the full comments on #152), unless you allow the request in the first place. So there should be a clear warning about path-based rules in the "Create rule" section of chrome://requestpolicy/content/settings/yourpolicy.html

Once this is done, it should be possible to allow requests to specific paths. However, considering the security/privacy implications, it should only be possible to do it manually from the "Create rule" section in the prefs (for advanced users) with that very clear warning.

Hopefully if there are enough contributions to subscriptions, manually allowing domains wil be less and less needed.

@nodiscc nodiscc changed the title Whitelist for filetypes Whitelist for filetypes/paths Dec 5, 2014
@myrdd
Copy link
Member

myrdd commented Dec 23, 2014

This is a duplicate of #299. I'm closing this issue.

@ghost the rules you'd like to create would better be made based on filetypes, see #256.

@myrdd myrdd closed this as completed Dec 23, 2014
@myrdd myrdd modified the milestone: after 1.0 Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants