Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Author] Author overview endpoint returns top works #1608

Merged
merged 5 commits into from
May 29, 2024
Merged

[Author] Author overview endpoint returns top works #1608

merged 5 commits into from
May 29, 2024

Conversation

yattias
Copy link
Contributor

@yattias yattias commented May 28, 2024 •
edited
Loading

  • Endpoint for fetching author overview. Initially this will be the top works of the author. In the next iteration, we will allow customization of the data returned here
  • Updated profile endpoint to include open_acccess_pct and achivements.

@yattias yattias requested a review from a team as a code owner May 28, 2024 00:00
@yattias yattias changed the title [Author] Author Overview endpoint returns top works [Author] Author overview endpoint returns top works May 28, 2024
yattias
yattias commented May 28, 2024
View reviewed changes
src/user/serializers.py

class Meta:
model = Author
fields = "__all__"

def get_headline(self, author):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method will be rewritten over the next few weeks. This is initial version that takes into account authors with no headline

gzurowski
gzurowski approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@gzurowski gzurowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

koutst
koutst approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@koutst koutst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yattias yattias merged commit fe7a0f8 into master May 29, 2024
1 check passed
@yattias yattias deleted the author/overview branch May 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzurowski gzurowski gzurowski approved these changes

@koutst koutst koutst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yattias @gzurowski @koutst