Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert encoding format for output files #70

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

simleo
Copy link
Collaborator

@simleo simleo commented Nov 9, 2023

#69 Converted format annotations only for input files (from primary_job.json). With this PR, the conversion happens for output files as well, if the format annotations are found in primary-output.json.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c27ed11) 97.62% compared to head (60689aa) 97.66%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   97.62%   97.66%   +0.03%     
==========================================
  Files          13       13              
  Lines        1983     2010      +27     
==========================================
+ Hits         1936     1963      +27     
  Misses         47       47              
Files Coverage Δ
src/runcrate/convert.py 97.95% <100.00%> (+0.05%) ⬆️
tests/test_cwlprov_crate_builder.py 99.89% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simleo simleo merged commit 3eec3bb into ResearchObject:main Nov 9, 2023
11 checks passed
@simleo simleo deleted the output_encoding_format branch November 9, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant