Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WoD fixes #9

Merged
merged 25 commits into from
Oct 15, 2014
Merged

WoD fixes #9

merged 25 commits into from
Oct 15, 2014

Conversation

Proditorx
Copy link
Contributor

Started working on making the addon usable in the WoD beta. Here's what I got so far. Includes some other bugfixes/touch ups that aren't WoD specific.

@Resike
Copy link
Owner

Resike commented Oct 11, 2014

Not sure, how active you are in Curse, so could i get your e-mail address?
In the next week i would like to start to transfer the project, and i need some assistance with some of the project properties.

@Proditorx
Copy link
Contributor Author

PMing you my email and skype @ curse

Resike added a commit that referenced this pull request Oct 15, 2014
@Resike Resike merged commit 2a6b53a into Resike:master Oct 15, 2014
@Proditorx
Copy link
Contributor Author

Noticed a few bugs with this yesterday, just didn't have time to fix it.

  • /reload when already in an arena = broken
  • something is broken with the tags module since my refactor (I've done most of my testing without tags)

I'll probably take a look tonight.

@Resike
Copy link
Owner

Resike commented Oct 15, 2014

I just started to working on it, i really like the changes you made.

@Resike
Copy link
Owner

Resike commented Oct 15, 2014

It seems to break everytime you reload ui, i couldn't find whats causing it yet.

@Proditorx
Copy link
Contributor Author

Always or when in an arena already?

PS. I keep commenting from the wrong account.

@Resike
Copy link
Owner

Resike commented Oct 15, 2014

Always, the only way to fix it, to create a new profile, and then thats gonna work untill the next reload/relog.

@Proditorx
Copy link
Contributor Author

That is strange, got a stack trace?

@Resike
Copy link
Owner

Resike commented Oct 15, 2014

I'm trying to track it down, but no luck so far.

@Resike
Copy link
Owner

Resike commented Oct 15, 2014

Sucesss, found the leak. Other questing what version number do you think we should continue? v4, v6, or just continue the v3 ones?

@Proditorx
Copy link
Contributor Author

Great!

Not sure, either 4.0.0 or 6.0.2-r1, I guess. On one hand I like using the same version as the current WoW client, but on the other hand SemVer makes it more clear when there are major changes.

@Resike
Copy link
Owner

Resike commented Oct 17, 2014

Could you enable the comments on the curse and curseforge pages? I had some people requested it, also it would be cool to get some feedback on 4.0.0.

@Proditorx Proditorx deleted the wod-fixes branch November 28, 2014 06:34
Resike added a commit that referenced this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants