Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert vector tile endpoint to ninja #225

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

mvandenburgh
Copy link
Member

Doing this first before integrating caching, since presumably we'll want to use ninja's native caching mechanism.

Copy link
Contributor

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested and this looks good.

Just making some notes for the future:

  • Maybe we want to break out the region into its own endpoint separate from the vector tiles. That way we don't have to do an intersection calculation on all regions if they aren't necessary.
  • The client side shouldn't probably add the observation/evaluation source until one of the them is selected. This prevents it from trying to grab MB of data with nothing visible.
  • The client site might also benefit from only turning on the vector tile after it is zoomed into some specific range to prevent multiple cascading vector calculations at the zooming moves in.
  • Adding an initial pre-filter with an array of configurationIds I think should make the endpoint much more responsive than it is by quickly filtering out items that don't need to be displayed instead of doing an intersection calculation on them.

@mvandenburgh mvandenburgh merged commit 970ef13 into main Jun 26, 2023
@mvandenburgh mvandenburgh deleted the vector-tiles-to-ninja branch June 26, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants