Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken demo - No FOLRI on reorientation #47

Closed
marcoscaceres opened this issue Mar 2, 2014 · 9 comments
Closed

Broken demo - No FOLRI on reorientation #47

marcoscaceres opened this issue Mar 2, 2014 · 9 comments
Labels

Comments

@marcoscaceres
Copy link
Contributor

@baamenabar, the "No FOLRI on reorientation" seems to have broken, so I'm disabling it. When you have a chance, can you take a look?

@anselmh
Copy link
Member

anselmh commented Mar 2, 2014

One point is to wrap the fallback img into <noscript> tags as we have picturefill running. I assume this is not the only demo where this is not used. This at least fixes the flashing of two images after load.

marcoscaceres pushed a commit that referenced this issue Mar 2, 2014
@marcoscaceres
Copy link
Contributor Author

We should think about removing all the demos, tbh.

The web is now full of excellent articles showing how to use picture.

@Wilto
Copy link
Member

Wilto commented Jun 10, 2014

+1. We could always get a list of real-world sites goin’ instead (see scottjehl/picturefill#258 )

@anselmh
Copy link
Member

anselmh commented Jun 10, 2014

I agree. We might not want to remove the demos at all but the references on our website (to not break existing slides, articles, etc?).

@marcoscaceres
Copy link
Contributor Author

yeah. good point.

@zcorpan
Copy link
Contributor

zcorpan commented Aug 7, 2014

At least the demos need updating to match the current spec.

@anselmh
Copy link
Member

anselmh commented Aug 7, 2014

We should do that and add a sign "outdated" to them while it’s not done. I’m on vacation until end of next week so I won’t be able to update them in the next days…

@anselmh anselmh added bug and removed bug labels Aug 7, 2014
@marcoscaceres
Copy link
Contributor Author

no probs, it's not an emergency. I just got back from vacation, so I'm trying to claw my way out of my inbox.

@marcoscaceres
Copy link
Contributor Author

Won't fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants