New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved request specific class fields to CMP fields or local variables to solve race conditions #67

Merged
merged 3 commits into from Aug 3, 2016

Conversation

Projects
None yet
3 participants
@Vanit
Collaborator

Vanit commented Aug 3, 2016

  • class fields requestingMsisdn and httpRequestType were merged into an internal class HttpRequest, which is saved as a CMP field
  • class fields for the CGI response were merged into an internal class CGIResponse, which is now explicitly passed to the http response method for output

Resolves #66

Monix
Moved requestingMsisdn and httpRequestType to a CMP field to fix race…
… conditions

Moved the CGI response fields to a container class to be passed down

@deruelle deruelle added the peer review label Aug 3, 2016

Monix added some commits Aug 3, 2016

Monix
Fixed bugs where mlp request formatting errors would throw an excepti…
…on from the request type not being set, and then double up the returned errors

@FerUy FerUy self-assigned this Aug 3, 2016

@FerUy FerUy merged commit 5e2952a into RestComm:master Aug 3, 2016

@FerUy FerUy removed the peer review label Aug 3, 2016

@FerUy

This comment has been minimized.

Contributor

FerUy commented Aug 3, 2016

Nicely done @monix, thanks!

@Vanit

This comment has been minimized.

Collaborator

Vanit commented Aug 3, 2016

No problem! :)

@FerUy FerUy added the bug label Aug 5, 2016

@FerUy FerUy added this to the 1.0.0 milestone Aug 5, 2016

@FerUy FerUy assigned Vanit and unassigned FerUy Aug 5, 2016

@FerUy

This comment has been minimized.

Contributor

FerUy commented Aug 5, 2016

@monix we have a problem with this PR.

GET requests works fine (e.g. http://127.0.0.1:8080/restcomm/gmlc/rest?msisdn=577438634) but when trying MLP request intended for success (not dummy number), we are getting this error:

$ curl -X POST -d @mlpreq.txt http://192.168.26.128:8380/restcomm/gmlc/mlp
`

<svc_result xmlns="MLP_SVC_RESULT_310.dtd" ver="3.1.0">

SYSTEM FAILURE
<add_info>IO failure generating XML</add_info>

</svc_result>`

Please notice yesterday I worked on issue #8 and merged the PR #68 , so you need to sync with master branch before fixing this. As you worked on this I believe you'll solve it faster, albeit I'll investigate too what could have happened.

@FerUy FerUy added bug and removed bug labels Aug 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment