Code quality fix - Collection.isEmpty() should be used to test for emptiness. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satanatoly
pushed a commit
that referenced
this pull request
Feb 21, 2018
…object. (#32) Fixing squid:S1481 - Unused local variables should be removed. (#31) Fixing squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. (#30) Fixing squid:S1596 - Collections.emptyList(), emptyMap() and emptySet() should be used (#29) Fixing squid:S1155 - Collection.isEmpty() should be used to test for emptiness. (#28) Fixing squid:S1905 - Redundant casts should not be used. (#27) Fixing squid:S2131- Primitives should not be boxed just for "String" conversion. (#26) Fixing squid:S1488 - Local Variables should not be declared and then immediately returned or thrown. (#25)
satanatoly
pushed a commit
that referenced
this pull request
Feb 21, 2018
…immediately returned or thrown. (#25) Fixing squid:S2131- Primitives should not be boxed just for "String" conversion. (#26) Fixing squid:S1905 - Redundant casts should not be used. (#27) Fixing squid:S1155 - Collection.isEmpty() should be used to test for emptiness. (#28) Fixing squid:S1596 - Collections.emptyList(), emptyMap() and emptySet() should be used (#29) Fixing squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. (#30) Fixing squid:S1481 - Unused local variables should be removed. (#31) Fixing squid:S1858 - "toString()" should never be called on a String object. (#32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule
squid:S1155 - Collection.isEmpty() should be used to test for emptiness.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1155
Please let me know if you have any questions.
Faisal Hameed