-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jSS7 Simulator: additional MAP operations for Location Services Management (LSM) #100
Comments
@f-alonso-vendrell just assigned this issue to you ;) |
Adding support for SRIforLCS in SS7 Simulator, need to do:
|
Nice @f-alonso-vendrell Maybe we could put LCS instead of LOCATION (i.e. MAP_LCS_TEST_CLIENT/SERVER). What do you think? I leave it up to you. |
sure, I was trying to set up a clear todo list for my team and myself so if some concept is wrong or the approach is not ok, it can be exposed before advancing in the wrong direction. BTW how is documentation generated? I am currenly reading directly the ascii-doc but if it already generated or I can generate with a mvn command it would be of great help for my eyes. |
just discovered that at: jss7\docs\userguide\sources-asciidoc\target\generated-docs\html-book the documentation is generated. |
Great @f-alonso-vendrell |
One question, are you able to access RestComm/gmlc#10 ? |
yes. I am reading information from there to get a picture. |
Great! |
Hello @FerUy @f-alonso-vendrell yes we need two "Testing tasks", one is GMLC server (I guess "Client") side and another - HLR / MSC / SGSN sides ("server"). For tasks names - please check the list of MAP operations there: https://github.com/RestComm/jss7/blob/master/map/MAPMessagesImplemented.ods MAP_LSM_TEST_CLIENT Please also check, which messages which side sends (GMLC and HLR/MSC/SGSN sides I mean) Fernando, do you know which is a proper messageflow ? Is is just sending a request / responsing or the messageflow may be more complicated ? |
Hi @vetss The message flow is portrayed here: RestComm/gmlc#10 (same diagram here) Regarding the acronym, LCS is used by 3GPP/LTE and other related organizations for referring to Location Services. For example, 3GPP TS 23.271 is titled "Functional stage 2 description of Location Services (LCS)". "Location Service Management Services" is used in 3GPP TS 29.002 (MAP spec) as the section title for these location services operations: Another acronym largely used and known in the industry is LBS (Location Based Services), which is more commercial than technical. So, although I'd rather stay with LCS, what about? |
Thanks @FerUy for your info, There is one more operation - "subscriberLocationReport - 86" that is sent TO GMLC (not from as for two others). I am not sure we need to have it. Just for your info. As for a name of the service - go ahead in this topic and select that you like more. |
Hi @vetss , We will need "subscriberLocationReport - 86" for some use cases involving deferred type of location information (Notification type of Geolocation in Restcomm Geolocation API -geofencing-), but for now let's focus on SRIforLCS and PSL (Immediate type of Geolocation in Restcomm Geolocation API). I choose LCS for the name of the service then :) |
Ok, I am going with the MAP_LCS_TEST_CLIENT, created following: new file: core/src/main/java/org/mobicents/protocols/ss7/tools/simulator/tests/map/TestMapLcsClientMan.java and modified corresponding modified: core/src/main/java/org/mobicents/protocols/ss7/tools/simulator/management/Instance_TestTask.java As the moment of this comment I have been able to show "sendRoutingInfoForLCSRequest not implemented yet" when clicking the button. As I plan to:
Let me know at what level of viability you would like to do pull request (e.g. is it ok to publish the SRIforLCS with parameters hardcoded or should they be configurable before publishing) After some testing I would like to request a feature on the Simulator, that would be a "Load Default Values for Side A/B" at top level, so once you have selected Layer 1, Layer 2, Layer 3 and TestTask you click that button and all layers get populated at once. |
@f-alonso-vendrell agreed with the plan. It's OK to go first with 1 (publish the SRIforLCS with hardcoded parameters ) and make pull request, then go to 2 and so on. |
Hello I just got to a point in which I run 2 simulators, the first one with MAP_LCS_TEST_CLIENT and the second one with SMS_TEST_SERVER (as I haven't done the server part yet). In the client part I am able to send SRIforLCS request (at least I think so). This is what I am sending: 98114 [AWT-EventQueue-0] DEBUG org.mobicents.protocols.ss7.tools.simulator.tests.map.TestMapLcsClientMan - MAPDialogLsm Crea On the server part (not implemented yet LCS) I get a message which says: 00:03:15,726 WARN [MAPStackImpl-Simulator] ApplicationContextName of non activated MAPService is received. Will send back TCAP Abort : 0, 4, 0, 0, 1, 0, 37, 3, which I guess makes sense since MAPServiceLsm is not active on that side. I would like to do a PR so you can check the code, how should I proceed? |
check an example in org.mobicents.protocols.ss7.tools.simulator.tests.sms.TestSmsClientMan |
Hello Vetss, so should I also do the counter part (MAP_LCS_TEST_SERVER) before PR? the client part which you are referring is working fine (I think so), the error is coming in the server part for which I haven't done anything. I will edit my previous post so that is clear. |
Hello @f-alonso-vendrell what do you mean "counter part" ? Yes, you need to provide both CLIENT and SERVER parts. Else it is impossible to check how well they are implemented. If both Simulator parts work fine then we can start to test of interconnecting of Simulator with some server. |
ok, proceeding... |
Server part completed, thanks @vetss for pointing out code for reference. I have pushed it into my fork. Ready to do PR. |
Hello @f-alonso-vendrell , I have just checked your pull request, thanks for your work.
|
Hello @vetss
|
Hello @f-alonso-vendrell
If we are saying of work steps we can do it step by step for sure. But the final version must contain parameters editing forms / storing of parameters into some configs. Even we have as for now an empty set of configurable parameters those forms must be present so all implementation follow the same standard and furter code update will be simple
I do not understand your fully. We need to have both client a nd server parts workable and test interconnections between two simulators (client - server) to be sure all is properly implemented before we will start of testing of interconnection of SS7 Simulator with some server like GMLC or other SS7 equipment.
We need to test JMX / HTTP accesses before we can say that the implementation is finished. This is of cause possible when both client and server parts are implemented. If you need some extra info for this part feel free to ask it. |
simulator is not working for me on netty-2 branch, added a comment on: https://gitter.im/RestComm/jss7 |
I have added your update #169 |
Hello @FerUy I am coding geranPositioningData, utranPositioningData for PSL Response, and in order to build it it requires a byte[], for what I have seen it requires a minimum of 2 and a max of 10. How should that be presented in the Params GUI? As a String with only HexValues e.g. "F3F2F1"? |
Hi @f-alonso-vendrell. I faced the same issue for LTE positioning (where Diameter is used). |
@FerUy - is this issue fixed ? |
No @vetss, let's postpone it for next release 8.1. |
Reopening. |
…S, MAP PSL and MAP SLR to jSS7 simulator, all tests working OK with selected values for all parameters involving each operation. Issue RestComm#100
Add MAP SRIforLCS, MAP PSL and MAP SLR to jSS7 simulator.
For more information, see RestComm/gmlc#10
The text was updated successfully, but these errors were encountered: