Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-276: M3UA silently hides transmission exception #277

Closed
wants to merge 1 commit into from

Conversation

okulikov
Copy link
Contributor

This PR replaces silent exit on IOException throwing

@vetss vetss added the bug label Dec 29, 2017
@vetss vetss added this to the 8.0.0 milestone Dec 29, 2017
@vetss vetss closed this Jan 2, 2018
@gsaslis
Copy link
Contributor

gsaslis commented Jan 24, 2018

@okulikov thanks for contributing this! 👍

I've just added this contribution as well next to your name in our Contributors Hall of Fame 👏 . I do see however that the way this was incorporated into our codebase, your name doesn't come up as one of our contributors. If you would like to open another PR so that we can merge this in properly, we'd be more than happy to do that.

On the other hand, I appreciate that you may have moved on, and can't bother with all this, so ... either way... just let me know ;)

@okulikov
Copy link
Contributor Author

@gsaslis thanks for the notice.

Unfortunately the entry you added to your Contributors Hall of Fame seems a bit not accurate. Can you please remove it?

@gsaslis
Copy link
Contributor

gsaslis commented Jan 25, 2018

Thanks for getting back to me @okulikov

Sorry, looks like I might have missed something - what's not accurate about it?

@okulikov
Copy link
Contributor Author

@gsaslis well, I think you did publish very limited list of contributions, so I would prefer to stay in
obscurity.

@gsaslis
Copy link
Contributor

gsaslis commented Jan 25, 2018

@okulikov if you would like to be removed from the list, that's absolutely fine!

However, to be clear, all I did now was to add this single contribution to the list. There was only one before that. If you're implying that there should have been more, I'd be more than happy to look into that for you and have it amended!! (I'm new around here so there might be some history I'm missing...)

Just let me know which way you'd like to go with this plz.

@okulikov
Copy link
Contributor Author

okulikov commented Jan 25, 2018

@gsaslis I appreciate your disturbance about contributors. To be short, I will be fine with automatic and public reference made by git (if it will fail due to some accidental merges not an issue for me) and I would like to be removed from the list. Thanks.

@gsaslis
Copy link
Contributor

gsaslis commented Jan 25, 2018

@okulikov ok done.

We'll try to make sure future git merges ensure proper attribution. Thanks for your understanding and - of course - for all your contributions. :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants