Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): add 'Type' to more endpoint responses #2089

Merged
merged 3 commits into from
Dec 10, 2023
Merged

feat(api): add 'Type' to more endpoint responses #2089

merged 3 commits into from
Dec 10, 2023

Conversation

wescopeland
Copy link
Member

Resolves #2081 (comment).

Adds "Type" value to achievements returned in:

  • API_GetAchievementsEarnedBetween
  • API_GetAchievementsEarnedOnDay
  • API_GetUserRecentAchievements
  • API_GetAchievementOfTheWeek

@wescopeland wescopeland requested a review from a team December 9, 2023 15:29
@wescopeland wescopeland mentioned this pull request Dec 10, 2023
Closed
@wescopeland wescopeland merged commit a4c95b8 into RetroAchievements:master Dec 10, 2023
5 checks passed
@wescopeland wescopeland deleted the api-endpoint-type-values branch December 10, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jamiras Jamiras Jamiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wescopeland @Jamiras