added missing vice-libretro cores, proper lr-mess support from emulationstation + other goodies #3109

valerino · 2020-04-20T10:19:08Z

added missing vice-libretro cores:

vic20 (lr-vice-xvic)
c16/plus4 (lr-vice-xplus4)
c128 (lr-vice-x128)
pet (lr-vice-xpet)

plus other non-libretro emulators:

sdltrs (TRS-80, updated version, still no proper fullscreen)
gsplus (Apple II/GS, works 100%)

all tested and working on latest retropie on a rpi4.

…RS-80, updated version)

…28), lr-vice-xpet (commodore pet)

…o fullscreen, no sound

…newly introduced scriptmodules/run_mess.sh which automatically creates the necessary config on-the-fly to run mame/mess cores from emulationstation

valerino · 2020-04-23T01:58:54Z

Great!!!! One little problem, I'm trying to install the lr-mess-bbcmicro ... and the option menu only shows: H Package help. No install option.

hi, lr-mess-bbcmicro is the only one i can't get to work, it crashes and i still haven't got why. if you read in the code, it works if you launch run_mess.sh manually but not from emulationstation :(

anyway, i added a bunch of other emulators today, check them out. tomorrow i'll try to add others :)

dankcushions · 2020-04-23T08:33:35Z

Hi, thanks! however my recommendation would be to have one emulator per PR. it's unlikely to be accepted with many emulators, since it's too much testing/review work.

mth75 · 2020-04-23T11:30:06Z

Great!!!! One little problem, I'm trying to install the lr-mess-bbcmicro ... and the option menu only shows: H Package help. No install option.

hi, lr-mess-bbcmicro is the only one i can't get to work, it crashes and i still haven't got why. if you read in the code, it works if you launch run_mess.sh manually but not from emulationstation :(

anyway, i added a bunch of other emulators today, check them out. tomorrow i'll try to add others :)

the bbcmicro starts for me ... games won't start however from the runcommand ... Make sure the bios files are in place.

valerino · 2020-04-23T11:50:54Z

Great!!!! One little problem, I'm trying to install the lr-mess-bbcmicro ... and the option menu only shows: H Package help. No install option.

hi, lr-mess-bbcmicro is the only one i can't get to work, it crashes and i still haven't got why. if you read in the code, it works if you launch run_mess.sh manually but not from emulationstation :(
anyway, i added a bunch of other emulators today, check them out. tomorrow i'll try to add others :)

the bbcmicro starts for me ... games won't start however from the runcommand ... Make sure the bios files are in place.

sure of course i've the bios files in place!
exactly, games do not start from the runcommand.sh, which is what gets launched by emulationstation.
can you verify that launching games this way, from the terminal (quit emulationstation first) works ?

/opt/retropie/configs/bbcmicro/run_mess.sh /opt/retropie/emulators/retroarch/bin/retroarch /opt/retropie/libretrocores/lr-mess/mess_libretro.so /opt/retropie/configs/bbcmicro/retroarch.cfg bbcb /home/pi/RetroPie/BIOS -flop1 /home/pi/RetroPie/roms/bbcmicro/Bruce\ Lee\ (Europe).ssd

this works for me, games gets launched correctly. i've to dig into what happens from runcommand.sh probably ..... as now, i've this problem only with bbc, other systems i'm working on all starts correctly.

valerino · 2020-04-23T12:14:54Z

Hi, thanks! however my recommendation would be to have one emulator per PR. it's unlikely to be accepted with many emulators, since it's too much testing/review work.

uhm ok, uhm .... well, problem is it started as a personal project, i have some commits which adds more than an emulator, some where i fix stuff in more than one, etc....
tell me how can i do and i'd try to rearrange stuff if i can.

mth75 · 2020-04-23T12:15:15Z

No, doesn't work for me.

-bash: syntax error near unexpected token `('

Seems the parsing of '(' causes problems

valerino · 2020-04-23T12:15:57Z

No, doesn't work for me.

-bash: syntax error near unexpected token `('

Seems the parsing of '(' causes problems

bash /opt/retropie/configs/bbcmicro/run_mess.sh /opt/retropie/emulators/retroarch/bin/retroarch /opt/retropie/libretrocores/lr-mess/mess_libretro.so /opt/retropie/configs/bbcmicro/retroarch.cfg bbcb /home/pi/RetroPie/BIOS -flop1 /home/pi/RetroPie/roms/bbcmicro/Bruce\ Lee\ (Europe).ssd

mth75 · 2020-04-23T12:21:20Z

No, doesn't work for me.
-bash: syntax error near unexpected token `('
Seems the parsing of '(' causes problems

bash /opt/retropie/configs/bbcmicro/run_mess.sh /opt/retropie/emulators/retroarch/bin/retroarch /opt/retropie/libretrocores/lr-mess/mess_libretro.so /opt/retropie/configs/bbcmicro/retroarch.cfg bbcb /home/pi/RetroPie/BIOS -flop1 /home/pi/RetroPie/roms/bbcmicro/Bruce\ Lee\ (Europe).ssd

Same error

valerino · 2020-04-23T12:46:48Z

No, doesn't work for me.
-bash: syntax error near unexpected token `('
Seems the parsing of '(' causes problems

bash /opt/retropie/configs/bbcmicro/run_mess.sh /opt/retropie/emulators/retroarch/bin/retroarch /opt/retropie/libretrocores/lr-mess/mess_libretro.so /opt/retropie/configs/bbcmicro/retroarch.cfg bbcb /home/pi/RetroPie/BIOS -flop1 /home/pi/RetroPie/roms/bbcmicro/Bruce\ Lee\ (Europe).ssd

Same error

that's really weird.....

~/valerinos/misc_emu_scripts/mkconfig(master) » bash --version
GNU bash, version 5.0.3(1)-release (arm-unknown-linux-gnueabihf)
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

can you verify this ?
it's a problem probably with the declaration of arrays/usage.
it's a problem to update bash in retropie ? shouldn't be.....

mth75 · 2020-04-23T13:51:58Z

GNU bash, version 5.0.3(1)-release (arm-unknown-linux-gnueabihf)
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

mth75 · 2020-04-23T13:52:15Z

Look the same.

valerino · 2020-04-23T14:01:08Z

Look the same.

uhm .... how possible ? are you sure you're using my latest commit ?
i tried with different shells (for commodity, i installed zsh too) and no problems. anyway that scripts gets run by bash anyway due to the #! in the beginning......

mth75 · 2020-04-23T14:10:04Z

Absolutely sure.

valerino · 2020-04-23T14:16:18Z

Absolutely sure.

i'm trying to think to possible causes, but i can't think any.
rpi4 or rpi3 ? i'm using rpi4, but if bash is the same version ..... really weird.
anyway, let's see if someone else has the same problem. if so, i'll delete the pull request and try to understand what's going on.
coz if you can't execute run_mess.sh, none of the lr-mess systems i added will work for sure.

joolswills · 2020-04-23T14:18:06Z

Sorry but this is best closed imho. Please discuss and do the development elsewhere first. PRs for finished and tested individual modules can be submitted later when ready and considered on an individual basis. Thanks.

valerino · 2020-04-23T14:20:33Z

Sorry but this is best closed imho. Please discuss and do the development elsewhere first. PRs for finished and tested individual modules can be submitted later when ready and considered on an individual basis. Thanks.

ok so, i will resubmit the lr-vice ones as individual, then i'll continue the lr-mess thing on my repo.

joolswills · 2020-04-23T14:24:31Z

Thanks.

mth75 · 2020-04-23T14:25:30Z

Absolutely sure.

i'm trying to think to possible causes, but i can't think any.
rpi4 or rpi3 ? i'm using rpi4, but if bash is the same version ..... really weird.
anyway, let's see if someone else has the same problem. if so, i'll delete the pull request and try to understand what's going on.
coz if you can't execute run_mess.sh, none of the lr-mess systems i added will work for sure.

Last reply from me (due to Joolswills request). I'll wait what happens when you got starting bbcmicro from ES in order. Maybe this solves my problem. I'm using a RPI4 btw. In the meantime, thx man!

joolswills · 2020-04-24T01:20:01Z

Just to add, I don't think we need a module per lr-vice target. I did a quick test and it can be done easily in the lr-vice module so I may implement this myself after testing. The GS module and sdltrs changes though look useful. Cheers.

mth75 · 2020-04-24T01:23:11Z

Making it easy for people to install a BBC Micro emulator (in this case with the lr-mess core) is a much requested feature/emulator. So maybe you could consider adding the lr-mess-bbcmicro to the exp. menu.

joolswills · 2020-04-24T01:24:32Z

I'm not against having a BBC emulator. But I prefer another route.

joolswills · 2020-04-24T01:25:47Z

I don't want a module per mess core type situation. But the main mess core can be improved of course.

joolswills · 2020-04-24T01:40:05Z

Regarding lr-vice we can do something like

diff --git a/scriptmodules/libretrocores/lr-vice.sh b/scriptmodules/libretrocores/lr-vice.sh
index ecc5962c..89e28535 100644
--- a/scriptmodules/libretrocores/lr-vice.sh
+++ b/scriptmodules/libretrocores/lr-vice.sh
@@ -16,14 +16,21 @@ rp_module_licence="GPL2 https://raw.githubusercontent.com/libretro/vice-libretro
 rp_module_section="exp"
 rp_module_flags=""
 
+function _get_targets_lr-vice() {
+    echo x64 x128 xpet xplus4 xvic
+}
+
 function sources_lr-vice() {
     gitPullOrClone "$md_build" https://github.com/libretro/vice-libretro.git
 }
 
 function build_lr-vice() {
     make -f Makefile.libretro clean
-    make -f Makefile.libretro
-    md_ret_require="$md_build/vice_x64_libretro.so"
+    local target
+    for target in $(_get_targets_lr-vice); do
+        make -f Makefile.libretro EMUTYPE="$target"
+        md_ret_require+=("$md_build/vice_${target}_libretro.so")
+    done
 }
 
 function install_lr-vice() {
@@ -41,6 +48,15 @@ function configure_lr-vice() {
     cp -R "$md_inst/data" "$biosdir"
     chown -R $user:$user "$biosdir/data"
 
-    addEmulator 1 "$md_id" "c64" "$md_inst/vice_x64_libretro.so"
+    local target
+    local name
+    for target in $(_get_targets_lr-vice); do
+        if [[ "$target" == "x64" ]]; then
+            name=""
+        else
+            name="-${target}"
+        fi
+        addEmulator 1 "$md_id${name}" "c64" "$md_inst/vice_${target}_libretro.so"
+    done
     addSystem "c64"
 }

I will look at this after the next image release though as that's the current priority.

valerino · 2020-04-28T09:26:05Z

Just to add, I don't think we need a module per lr-vice target. I did a quick test and it can be done easily in the lr-vice module so I may implement this myself after testing. The GS module and sdltrs changes though look useful. Cheers.

sure, it can be done that way too. i have all these stuff hanging around since ages, just now i decided to clean it up and try to help. that was just one of my first experiments with retropie setup scripting, and thought it may help

valerino · 2020-04-28T09:28:28Z

I don't want a module per mess core type situation. But the main mess core can be improved of course.

have you tried my method ? i think it's a clean solution, and the systems are isolated each other. look on my post on https://retropie.org.uk/ forum, i added many (almost 30), all working.
sure it may be improved, i myself already thought to isolate the lr-mess-xxxx in a separate menu.

valerino added 4 commits April 19, 2020 15:58

added lr-vice-xvic (commodore vic20), gsplus (Apple II/gs), sdltrs (T…

e06519a

…RS-80, updated version)

added lr-vice-xvic (commodore vic20), gsplus (Apple II/gs), sdltrs (T…

6ceeba3

…RS-80, updated version)

added lr-vice-xplus4 (commodore c16/plus4), lr-vice-x128 (commodore 1…

1cb2be2

…28), lr-vice-xpet (commodore pet)

fixed sdltrs

f5df3ce

valerino closed this Apr 20, 2020

valerino reopened this Apr 20, 2020

valerino added 11 commits April 20, 2020 12:30

fixed help screen for trs80

397af11

added beebem (micro bbc), though not fully working: games playable, n…

3d72640

…o fullscreen, no sound

added lr-mess-bbcmicro.sh and lr-mess-crvsion.sh, all leveraging the …

3af7f70

…newly introduced scriptmodules/run_mess.sh which automatically creates the necessary config on-the-fly to run mame/mess cores from emulationstation

couple of fixes

6c7139e

added lr-mess-apple2gs.sh

4fb5e51

added lr-mess-apple2.sh

911422b

added lr-mess-coco.sh

a9eac3d

cosmetics

7ba2a3d

Merge remote-tracking branch 'upstream/master'

6b03cb5

added lr-mess-trs-80.sh

35596f9

cosmetics

bdae16b

Merge branch 'master' into master

ec96482

valerino changed the title ~~added missing vice-libretro cores + other goodies~~ added missing vice-libretro cores, proper lr-mess support from emulationstation + other goodies Apr 23, 2020

valerino closed this Apr 23, 2020

valerino mentioned this pull request Apr 23, 2020

error executing run_mess.sh valerino/RetroPie-Setup#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added missing vice-libretro cores, proper lr-mess support from emulationstation + other goodies #3109

added missing vice-libretro cores, proper lr-mess support from emulationstation + other goodies #3109

valerino commented Apr 20, 2020

valerino commented Apr 23, 2020

dankcushions commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020 •

edited

Loading

valerino commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020 •

edited

Loading

mth75 commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020

joolswills commented Apr 23, 2020

valerino commented Apr 23, 2020

joolswills commented Apr 23, 2020

mth75 commented Apr 23, 2020 •

edited

Loading

joolswills commented Apr 24, 2020

mth75 commented Apr 24, 2020

joolswills commented Apr 24, 2020

joolswills commented Apr 24, 2020

joolswills commented Apr 24, 2020 •

edited

Loading

valerino commented Apr 28, 2020

valerino commented Apr 28, 2020

added missing vice-libretro cores, proper lr-mess support from emulationstation + other goodies #3109

added missing vice-libretro cores, proper lr-mess support from emulationstation + other goodies #3109

Conversation

valerino commented Apr 20, 2020

valerino commented Apr 23, 2020

dankcushions commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020 • edited Loading

valerino commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020 • edited Loading

mth75 commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020

mth75 commented Apr 23, 2020

valerino commented Apr 23, 2020

joolswills commented Apr 23, 2020

valerino commented Apr 23, 2020

joolswills commented Apr 23, 2020

mth75 commented Apr 23, 2020 • edited Loading

joolswills commented Apr 24, 2020

mth75 commented Apr 24, 2020

joolswills commented Apr 24, 2020

joolswills commented Apr 24, 2020

joolswills commented Apr 24, 2020 • edited Loading

valerino commented Apr 28, 2020

valerino commented Apr 28, 2020

valerino commented Apr 23, 2020 •

edited

Loading

valerino commented Apr 23, 2020 •

edited

Loading

mth75 commented Apr 23, 2020 •

edited

Loading

joolswills commented Apr 24, 2020 •

edited

Loading