Fixes to ensure answers shared to twitter post more reliably #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raccube
force-pushed
the
fix/tweet-length
branch
from
3663614
to
b0fce22
Compare
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 59.91% 61.10% +1.18%
==========================================
Files 88 88
Lines 2068 2072 +4
==========================================
+ Hits 1239 1266 +27
+ Misses 829 806 -23
Continue to review full report at Codecov.
|
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
nilsding
requested changes
Dec 25, 2021
| it "posts a shortened tweet" do | ||
| service.post(answer) | ||
|
|
||
| expect(twitter_client).to have_received(:update!).with("#{'q' * 123}… — #{'a' * 124}… https://example.com/#{user.screen_name}/a/#{answer.id}") |
There was a problem hiding this comment.
please also add another one for testing unshortened texts
|
|
nilsding
approved these changes
Dec 25, 2021
pixeldesu
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99