Fix setting disabling by LUA for non-Host players #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
fixplayerlua
branch
3 times, most recently
from
4effa4e
to
bf62bb9
Compare
Flamefire
force-pushed
the
fixplayerlua
branch
3 times, most recently
from
bdd52dd
to
9df585b
Compare
Flamefire
force-pushed
the
fixplayerlua
branch
3 times, most recently
from
e2a97f3
to
3a7441a
Compare
auto-merge was automatically disabled
June 28, 2024 17:34
Pull Request is not mergeable
Makes the code more readable by removing the need to check for existing lua script each time.
The lua script was only loaded for the host as many function are intended for the host, especially the lobbyController. Load for all players and guard relevant parts for the host only. Fixes Return-To-The-Roots#1660
|
@Flow86 Any idea what is wrong with Jenkins? It failed but the log is so large it doesn't even show properly |
|
@Flow86 Can you merge this? It needs a review approval which I can't do if I'm the author |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lua script was only loaded for the host as many function are intended for the host, especially the lobbyController.
Load for all players and guard relevant parts for the host only.
Fixes #1660