Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostics data tracking #1651

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Mar 20, 2024

@tonidero tonidero added the refactor A code change that neither fixes a bug nor adds a feature label Mar 20, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.51%. Comparing base (cb4e348) to head (72b1c65).
Report is 12 commits behind head on main.

❗ Current head 72b1c65 differs from pull request most recent head f3c81db. Consider uploading reports for the commit f3c81db to get more accurate results

Files Patch % Lines
.../purchases/common/diagnostics/ResponseTimeRange.kt 66.66% 2 Missing and 2 partials ⚠️
.../revenuecat/purchases/CustomerInfoUpdateHandler.kt 66.66% 0 Missing and 1 partial ⚠️
...purchases/common/diagnostics/DiagnosticsTracker.kt 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
+ Coverage   83.46%   83.51%   +0.05%     
==========================================
  Files         221      222       +1     
  Lines        7485     7545      +60     
  Branches     1051     1058       +7     
==========================================
+ Hits         6247     6301      +54     
- Misses        827      830       +3     
- Partials      411      414       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero marked this pull request as ready for review March 25, 2024 15:33
@tonidero tonidero requested a review from a team March 25, 2024 15:33
@tonidero tonidero added HOLD and removed HOLD labels Apr 2, 2024
Based off #1651 

Creates Counters for posting Amazon diagnostics. This PR doesn't send
the counters, that will go in a separate PR.

---------

Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
@tonidero tonidero enabled auto-merge (squash) April 8, 2024 08:13
@tonidero tonidero merged commit 0c044ed into main Apr 8, 2024
7 checks passed
@tonidero tonidero deleted the sdk-3395-android-improve-data-tracked-through-diagnostics-so-it-can branch April 8, 2024 08:33
tonidero added a commit that referenced this pull request Apr 11, 2024
**This is an automatic release.**

### Dependency Updates
* Bump fastlane from 2.219.0 to 2.220.0 (#1668) via dependabot[bot]
(@dependabot[bot])
### Other Changes
* Add store entry for External Purchases API (#1664) via Mark Villacampa
(@MarkVillacampa)
* Remove confusing placements error log (#1670) via Toni Rico
(@tonidero)
* Improve diagnostics data tracking (#1651) via Toni Rico (@tonidero)

---------

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants