Remove confusing placements error log #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
added
the
refactor
tonidero
added a commit
that referenced
this pull request
Apr 11, 2024
**This is an automatic release.** ### Dependency Updates * Bump fastlane from 2.219.0 to 2.220.0 (#1668) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Add store entry for External Purchases API (#1664) via Mark Villacampa (@MarkVillacampa) * Remove confusing placements error log (#1670) via Toni Rico (@tonidero) * Improve diagnostics data tracking (#1651) via Toni Rico (@tonidero) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes an error log which was happening even in normal situations. The response from the backend may have a
placementskey with only a fallback, but nooffering_ids_by_placement, which was logging it as an error, which it wasn't