Changes _Nullable to nullable and nonnull cleanup #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeiting
approved these changes
Sep 26, 2019
vegaro
pushed a commit
that referenced
this pull request
Sep 27, 2019
* Proposal for packages. * Offerings and packages continuation (#121) * Adds factory of Offerings * Changes entitlements with offerings (#122) * Changes entitlements with offerings * Fixes old tests * style changes * Cleaner way to map package types * Makes offeringsfactory instance and makes some changes on the package type string names * Fixes dead tests * package type string conversion changes * Injects offeringsFactory and makes current offering nullable * formats RCPromotionalOffer * Moves offeringsFactory assignment with the other setters * Post receipt presented offering (#123) * Adds factory of Offerings * Changes entitlements with offerings (#122) * Changes entitlements with offerings * Fixes old tests * Changes entitlements with offerings * Changes purchase call * style changes * Cleaner way to map package types * Makes offeringsfactory instance and makes some changes on the package type string names * Fixes dead tests * package type string conversion changes * Injects offeringsFactory and makes current offering nullable * Fixes build * formats RCPromotionalOffer * fixes build * Updates docs * fixes code style * Removed description from header * Renames to presentedOfferingsByProductIdentifier * Use properties to make access prettier. * Add unavailable macros to push people to new methods. * Use a macro to clean up the attribute stuff. * BackendTests update * renames currentOffering to current * Sends error if backend sends a bad response * Adds presentedOfferingIdentifier to the cache key to avoid repeated calls * Updates copyright headers * Removes deprecated stuff * updated sample * changes nullability annotations (#126) * updated project settings * Adds missing docs (#128) * Adds todos to missing docs * RCEntitlementinfo docs * More docs * Finishes docs * fixes typos * Adds RCPackageTypeUnknown
vegaro
added a commit
that referenced
this pull request
Nov 13, 2019
* Packages (#115) * Proposal for packages. * Offerings and packages continuation (#121) * Adds factory of Offerings * Changes entitlements with offerings (#122) * Changes entitlements with offerings * Fixes old tests * style changes * Cleaner way to map package types * Makes offeringsfactory instance and makes some changes on the package type string names * Fixes dead tests * package type string conversion changes * Injects offeringsFactory and makes current offering nullable * formats RCPromotionalOffer * Moves offeringsFactory assignment with the other setters * Post receipt presented offering (#123) * Adds factory of Offerings * Changes entitlements with offerings (#122) * Changes entitlements with offerings * Fixes old tests * Changes entitlements with offerings * Changes purchase call * style changes * Cleaner way to map package types * Makes offeringsfactory instance and makes some changes on the package type string names * Fixes dead tests * package type string conversion changes * Injects offeringsFactory and makes current offering nullable * Fixes build * formats RCPromotionalOffer * fixes build * Updates docs * fixes code style * Removed description from header * Renames to presentedOfferingsByProductIdentifier * Use properties to make access prettier. * Add unavailable macros to push people to new methods. * Use a macro to clean up the attribute stuff. * BackendTests update * renames currentOffering to current * Sends error if backend sends a bad response * Adds presentedOfferingIdentifier to the cache key to avoid repeated calls * Updates copyright headers * Removes deprecated stuff * updated sample * changes nullability annotations (#126) * updated project settings * Adds missing docs (#128) * Adds todos to missing docs * RCEntitlementinfo docs * More docs * Finishes docs * fixes typos * Adds RCPackageTypeUnknown * Version 3.0.0-beta * Adds unknown case to switch cases * Changes swift names to start with Purchases. (#134) * Crash when a removed product is still in a transaction in the queue (#136) * Failing Test * checks for nil product * Changes test name * Adds access to "all" offerings (#137) * Exposes all offerings * Updates sample swift * Version 3.0.0-beta.2 * Enable base internationalisation (#119) This silences a warning from Xcode and has no impact because this framework has no localised resources. * New Identity changes (#133) * Adds changes to identity * Fixes tests * Fixes the compilation * PR comments * PR comments * Compilation issues * Remove todo * removes unused error * Renames to RCIdentityManager * Migrates tests to Swift 5 (#138) * Migrates to Swift 5 * Updates test to match nil instead of empty * Updates swift in sample app * Version 3.0.0-beta.3 * fixes compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes existing
_Nullablewithnullablewherever it's possible because they are nicer. https://developer.apple.com/swift/blog/?id=25