Enable explicit_init lint rule and fix issues #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkVillacampa
added
the
style
NachoSoto
approved these changes
Nov 15, 2023
| @@ -75,7 +75,7 @@ private extension StoreProductDiscount.PaymentMode { | |||
| case .freeTrial: | |||
| self = .freeTrial | |||
| @unknown default: | |||
| Logger.appleWarning(Strings.storeKit.skunknown_payment_mode(String.init(describing: paymentMode))) | |||
| Logger.appleWarning(Strings.storeKit.skunknown_payment_mode(.init(describing: paymentMode))) | |||
There was a problem hiding this comment.
Can we do
Suggested change
| Logger.appleWarning(Strings.storeKit.skunknown_payment_mode(.init(describing: paymentMode))) | |
| Logger.appleWarning(Strings.storeKit.skunknown_payment_mode(paymentMode.rawValue)) |
That doesn't use reflection so it's a lot faster
There was a problem hiding this comment.
Sadly it's a UInt enum :(
There was a problem hiding this comment.
Then String(enum.rawValue). Describing uses runtime reflection and it's A LOT slower.
There was a problem hiding this comment.
You already merged so it's fine. It was already like this anyway.
There was a problem hiding this comment.
And it's not like this is a hot path.
| @@ -60,7 +60,7 @@ private extension StoreProductDiscount.PaymentMode { | |||
| case .freeTrial: | |||
| self = .freeTrial | |||
| default: | |||
| Logger.appleWarning(Strings.storeKit.skunknown_payment_mode(String.init(describing: paymentMode))) | |||
| Logger.appleWarning(Strings.storeKit.skunknown_payment_mode(.init(describing: paymentMode))) | |||
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3418 +/- ##
=======================================
Coverage 86.07% 86.07%
=======================================
Files 237 237
Lines 17201 17201
=======================================
Hits 14805 14805
Misses 2396 2396 ☔ View full report in Codecov by Sentry. |
tonidero
pushed a commit
that referenced
this pull request
Nov 30, 2023
**This is an automatic release.** ### RevenueCatUI * Paywalls: Fix navigation with close button in UIKit (#3466) via Andy Boedo (@aboedo) * `Paywalls`: `watchOS` support (#3291) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump cocoapods from 1.14.2 to 1.14.3 (#3464) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.216.0 to 2.217.0 (#3415) via dependabot[bot] (@dependabot[bot]) * Bump danger from 9.3.2 to 9.4.0 (#3414) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Some `APITester` fixes (#3444) via NachoSoto (@NachoSoto) * `HTTPClient`: test all request headers (#3425) via NachoSoto (@NachoSoto) * `CircleCI`: fix snapshot generation for iOS 14 (#3431) via NachoSoto (@NachoSoto) * Remove `MockStoreMessagesHelper` from SDK (#3417) via NachoSoto (@NachoSoto) * Enable explicit_init lint rule and fix issues (#3418) via Mark Villacampa (@MarkVillacampa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule will warn when calling
initwith the explicit type where it can be inferred, or where the.initpart can be omitted.