-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paywalls
: watchOS
support
#3291
Conversation
NachoSoto
commented
Oct 9, 2023
14407f7
to
17a1f48
Compare
@@ -72,7 +72,7 @@ private extension BackendPaywallEventTests { | |||
offeringIdentifier: "offering_1", | |||
paywallRevision: 5, | |||
sessionID: .init(uuidString: "98CC0F1D-7665-4093-9624-1D7308FFF4DB")!, | |||
displayMode: .condensedFooter, | |||
displayMode: .fullScreen, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.fullScreen
is the only available on in watchOS
, so I changed this to fix those tests.
aaa8455
to
caa4b31
Compare
caa4b31
to
480c5b5
Compare
895851d
to
a3623bc
Compare
23ff954
to
e27fec7
Compare
ed5dce9
to
9d38c3e
Compare
RevenueCatUI/Data/TestData.swift
Outdated
@@ -521,6 +529,14 @@ internal enum TestData { | |||
type: .introductory | |||
) | |||
} | |||
|
|||
#if os(watchOS) | |||
// `Locale.current` in watchOS produces `en_001` when running tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -15,6 +15,8 @@ import RevenueCat | |||
import SwiftUI | |||
|
|||
@available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | |||
@available(tvOS, unavailable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to remove the watchOS
from the lines above each of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't add it it assumes the requirement matches the deployment target in the target which is 6.2 so it fails to compile.
if #unavailable(watchOS 10.0) { | ||
Color.black | ||
} | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, in the else case, I guess this will be nil, so there won't be any background, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct.
4ea9729
to
9e2e51b
Compare
@@ -24,7 +24,7 @@ | |||
"tos_url" : null | |||
}, | |||
"localized_strings" : { | |||
"en_001" : { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is broken on watchOS + Xcode 15
214db96
to
7068c6a
Compare
**This is an automatic release.** ### RevenueCatUI * Paywalls: Fix navigation with close button in UIKit (#3466) via Andy Boedo (@aboedo) * `Paywalls`: `watchOS` support (#3291) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump cocoapods from 1.14.2 to 1.14.3 (#3464) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.216.0 to 2.217.0 (#3415) via dependabot[bot] (@dependabot[bot]) * Bump danger from 9.3.2 to 9.4.0 (#3414) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Some `APITester` fixes (#3444) via NachoSoto (@NachoSoto) * `HTTPClient`: test all request headers (#3425) via NachoSoto (@NachoSoto) * `CircleCI`: fix snapshot generation for iOS 14 (#3431) via NachoSoto (@NachoSoto) * Remove `MockStoreMessagesHelper` from SDK (#3417) via NachoSoto (@NachoSoto) * Enable explicit_init lint rule and fix issues (#3418) via Mark Villacampa (@MarkVillacampa)