Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paywalls: improve template 5 landscape layout #3534

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Paywalls: improve template 5 landscape layout #3534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6672c5a
`Paywalls`: improve template 5 landscape layout
NachoSoto Dec 20, 2023
933161b
New Spacer
NachoSoto Dec 21, 2023
d5d6630
Update snapshots
NachoSoto Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions RevenueCatUI/Templates/Template5View.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ struct Template5View: TemplateViewType {
@ViewBuilder
var horizontalContent: some View {
VStack {
Spacer()

HStack {
VStack {
self.title
Expand All @@ -82,6 +84,8 @@ struct Template5View: TemplateViewType {
.scrollableIfNecessary()
}

Spacer()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious but how does this look on an iPad in landscape? Just wondering whether the main content will be moved too much to the top, since I think we might want it centered within the available space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iPad landcape doesn't have "vertical height condensed", so this layout isn't used.


self.subscribeButton

self.footerView
Expand Down
2 changes: 1 addition & 1 deletion Tests/purchases-ios-snapshots-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b35f913b6fa993153905fe43a6bc6eadbd27be9e
b7340baaf383d91bb59b038fd379d31368860080