Logging v2 part 2 #399
Merged
Logging v2 part 2 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Nov 17, 2020
Comment on lines
+588
to
594
| RCWarnLog(@"allowSharingAppStoreAccount is set to false and restoreTransactions has been called. " | ||
| "Are you sure you want to do this?"); |
There was a problem hiding this comment.
these feel more like warnings to me, but we didn't use to have a warn level
aboedo
force-pushed
the
logging_v2_part_2
branch
from
116a6db
to
edece08
Compare
vegaro
approved these changes
Nov 20, 2020
| @@ -51,7 +51,7 @@ extension ProductsManager: SKProductsRequestDelegate { | |||
|
|
|||
| func productsRequest(_ request: SKProductsRequest, didReceive response: SKProductsResponse) { | |||
| queue.async { [self] in | |||
| NSLog("products request received response") | |||
| Logger.info("products request received response") | |||
There was a problem hiding this comment.
I'm honestly not sure which is best here. I was kind of torn because of stuff like #250. I might improve the message a bit so that it's more useful.
There was a problem hiding this comment.
I should also make it consistent with line 70, where I'm using debug, so that either they're both debug or both info
aboedo
force-pushed
the
logging_v2_part_2
branch
from
4dd534d
to
cd4ae58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved API for logging in Swift.
Added a few log entries to Swift code.
Requirements:
Based on Logging v2: part 1 #395