Fix purchaseSubscriptionOption not accepting oldProductIdentifier #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
approved these changes
Nov 2, 2023
tonidero
deleted the
fix-purchase-subscription-option-not-accepting-new-field
branch
NachoSoto
pushed a commit
that referenced
this pull request
Nov 8, 2023
**This is an automatic release.** ### Bugfixes * Fix purchaseSubscriptionOption not accepting oldProductIdentifier (#764) via Toni Rico (@tonidero) ### Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 7.3.0 (#765) via RevenueCat Git Bot (@RCGitBot) * [Android 7.2.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.2.0) * [Android 7.1.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.1.1) * [Android 7.1.0](https://github.com/RevenueCat/purchases-android/releases/tag/7.1.0) * [Android 7.1.0-beta.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.1.0-beta.2) * [Android 7.1.0-beta.1](https://github.com/RevenueCat/purchases-android/releases/tag/7.1.0-beta.1) * [iOS 4.30.2](https://github.com/RevenueCat/purchases-ios/releases/tag/4.30.2) * [iOS 4.30.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.30.1) * [iOS 4.30.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.30.0) --------- Co-authored-by: RevenueCat CI <dev+ci@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #763, we were using the
oldSKUfor google upgrades but the typescript interface only acceptsoldProductIdentifierin thepurchaseSubscriptionOptionmethod. This makes sure all purchase methods have the same logic. Note thatpurchaseSubscriptionOptiondidn't exist before V5, but since some developers might have worked around the issue by usingoldSKU, I think it's better to support that and avoid breaking their fixes.