Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #24, allow multiple PATHs to be provided #25

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

garrison
Copy link
Contributor

No description provided.

Copy link
Member

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

I manually tested by pulling your fork, looks good. I just left one small comment.

If possible, can you please add some tests here - https://github.com/ReviewNB/treon/blob/master/tests/test_treon.py ?

treon/treon.py Show resolved Hide resolved
@garrison
Copy link
Contributor Author

garrison commented Aug 2, 2022

I added a test. It assumes that py.test is invoked from the base of the repository. (I'll note that the filter_results tests have the same paths written without the tests/ in front; however, they work regardless of where py.test is invoked from, as they do not actually look at the filesystem.)

@garrison
Copy link
Contributor Author

garrison commented Aug 3, 2022

I thought of a way to make py.test work from any directory and pushed the change.

@amit1rrr amit1rrr merged commit 7daac88 into ReviewNB:master Aug 4, 2022
@amit1rrr
Copy link
Member

amit1rrr commented Aug 4, 2022

Thanks @garrison

I've merged this PR & released a new version (0.1.4). Please give this a try when you can.

I also added some more tests following your pattern.

Thanks again for your contribution. Cheers!

@garrison garrison deleted the multiple-paths branch August 4, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants