Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicating a cell type plays the placement sound even though it doesn't place anything #4578

Closed
hhyyrylainen opened this issue Nov 24, 2023 · 3 comments · Fixed by #5092
Closed

Comments

@hhyyrylainen
Copy link
Member

probably something to do with a wrong left click listener getting as far as playing the sound

@hhyyrylainen hhyyrylainen added this to Backburner in Thrive Planning via automation Nov 24, 2023
@hhyyrylainen hhyyrylainen moved this from Backburner to Low priority bugs / issues in Thrive Planning Nov 24, 2023
@CI09
Copy link
Contributor

CI09 commented Nov 29, 2023

It may be due to button for duplicating cell type calls same action function as placing cells and this function always play placement sound when successful.

@hhyyrylainen
Copy link
Member Author

That could also happen. Still it's much faster than speculating to just check things in a debugger to see where the two flows go and where the accidental click sound is triggered from.

@CI09
Copy link
Contributor

CI09 commented Apr 19, 2024


Seems like this function (that currently only plays placement sound) is called in EnqueueAction which is a general method (not only for placing).

@hhyyrylainen hhyyrylainen added this to the Release 0.6.7 milestone Apr 28, 2024
@hhyyrylainen hhyyrylainen moved this from Low priority bugs / issues to In progress in Thrive Planning Apr 28, 2024
Thrive Planning automation moved this from In progress to Done Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment