Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfast causes R to hang #16

Closed
jkeuskamp opened this issue Mar 20, 2020 · 13 comments
Closed

Rfast causes R to hang #16

jkeuskamp opened this issue Mar 20, 2020 · 13 comments
Assignees
Labels
bug Something isn't working

Comments

@jkeuskamp
Copy link

jkeuskamp commented Mar 20, 2020

using the rowMins function causes the 'Rsession' process to become unstable. Within a short period of time after using rowMins, R becomes unresponsive without obvious reason. It always happens upon execution of a statement, but it doesn't seem exactly reproducable i.e. sometimes the same run of statements may run fine, while other times it hangs immediately.

This problem makes this package unusable in my case.
This problem occurred with the latest version of base (3.6.3) installed on macOS 10.15.2 with the following packages loaded:

"base"       "data.table" "datasets"   "dplyr"      "dtplyr"     "forcats"    "ggplot2"    "graphics"  
"grDevices"  "lubridate"  "methods"    "openxlsx"   "pacman"     "progress"   "purrr"      "readr"     
"readxl"     "recipes"    "stats"      "stringr"    "tibble"     "tibbletime" "tidyr"      "tidyverse" 
"timetk"     "units"      "utils"      "xts"        "zoo"
@ManosPapadakis95
Copy link
Contributor

Can you give me the examples that crashed R?

@jkeuskamp
Copy link
Author

jkeuskamp commented Mar 21, 2020 via email

@ManosPapadakis95
Copy link
Contributor

It crashes in a specific command that you use rowMins? That doesn't make any sense. If you can't reproduce error then it might not be Rfast's problem. We have checked the function and it works perfectly. Any idea what to do?

@jkeuskamp
Copy link
Author

jkeuskamp commented Mar 22, 2020 via email

@ManosPapadakis95
Copy link
Contributor

I don't know how to help.... If you find any example that R crashes let me know.

@tjfarrar
Copy link

I am also having some such problems. For instance, if I call

Rfast::mat.mult(diag(4), diag(5))
it not only throws an error (as it should) but crashes the R session. I am running R version 3.6.2 (64-bit) on Windows 8. I tried also in R-devel with same result. It happens in RStudio and in RGui.

Even some matrices with conformable dimensions also caused such a crash. For example,
X <- matrix(data = runif(100 * 2), nrow = 100, ncol = 2)
Rfast::mat.mult(Rfast::transpose(X), X)

The error thrown is

Mat::col(): index out of bounds

The R session crashes with a dialogue:

Runtime Error! Rgui.exe This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information.

Maybe this is not an issue with your package per se, but I have never had this happen with any other R function.

@ManosPapadakis95
Copy link
Contributor

I am also having some such problems. For instance, if I call

Rfast::mat.mult(diag(4), diag(5))
it not only throws an error (as it should) but crashes the R session. I am running R version 3.6.2 (64-bit) on Windows 8. I tried also in R-devel with same result. It happens in RStudio and in RGui.

Even some matrices with conformable dimensions also caused such a crash. For example,
X <- matrix(data = runif(100 * 2), nrow = 100, ncol = 2)
Rfast::mat.mult(Rfast::transpose(X), X)

The error thrown is

Mat::col(): index out of bounds

The R session crashes with a dialogue:

Runtime Error! Rgui.exe This application has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information.

Maybe this is not an issue with your package per se, but I have never had this happen with any other R function.

I have already fix this bug for the next update.

@tjfarrar
Copy link

I have already fix this bug for the next update.

When can we expect the next update on CRAN? Is it possible to make the development version available on Github in the meantime? I see that it is still only version 1.9.9 that is available on Github (same as on CRAN).

@ManosPapadakis95
Copy link
Contributor

I have already fix this bug for the next update.

When can we expect the next update on CRAN? Is it possible to make the development version available on Github in the meantime? I see that it is still only version 1.9.9 that is available on Github (same as on CRAN).

I don't know... Download github version. I have fix it.

@tjfarrar
Copy link

Thanks. A suggestion would be to follow the naming conventions for development versions of a package, e.g. 1.9.9.9001. See here. Otherwise people will assume that version 1.9.9 on Github is identical to version 1.9.9 on CRAN.

@ManosPapadakis95 ManosPapadakis95 added the bug Something isn't working label Jan 30, 2021
@nassuphis
Copy link

nassuphis commented Jan 30, 2021

rowOrder() still causes a crash, i used the github version
actually, i got this error after a long freeze:

Error: C stack usage 7971028 is too close to the limit

@ManosPapadakis95
Copy link
Contributor

ManosPapadakis95 commented Jan 30, 2021 via email

@nassuphis
Copy link

on it. will report back once i have a repeatable example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants