Import stop on errors #1486
Closed
Import stop on errors #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oPromessa thanks for this. I'm going to hold off incorporating this for now because I'm in the middle of a big update to the import code and this may cause merge conflicts. I'll take a look at your changes once I'm done. I'm trying to add support for Live Photos, RAW+JPEG pairs, burst photos, and AAE files in the import code. This has required a rewrite of much of the import code. |
|
@oPromessa I've merged this into the importapalooza branch which will bring many updates to import. Thanks for the contribution! |
RhetTbull
added a commit
that referenced
this pull request
Jun 8, 2024
* Working on import fixes * Working on --check * More work on import check * Got import check working * Initial refactor of --check-not * Working on import code * Tests passing for import * Fixed reporting for import * Fixes #1470, apply sidecar to _edited photos, adds --edited-suffix * Implements #1373, --favorite-rating * Updated docs * Implemented --auto-live, #1399 * Normalizes unicode for album names, #1475 * Added height, width to PhotoInfoFromFile * Updated test names * Adds --signature to import, #1374 * Fix test for linux * Implements PR #1486 * Allow import to accept files or directories as argument * Fixed error with files_or_dirs * Added export_directory table * ExportDB updates to allow reading last export path * Added --runs to exportdb, updated exportdb tests * Added photoinfo_from_dict * Added photoinfo_from_dict tests * Added --exportdb to import * Stage files that need modification, added tests * Refactoring for maintainability * Refactoring for maintainability * Refactoring for maintainability * Changed verbose level * Fix for files with same stemp when --auto-live is not used * Handled edited version w/o AAE * removed print statemetns * Updated check, check not * Added tests for importing edited versions * Refactored to move import_cli code first in file * Working on _edited photos * Import of edited files now working * Updated content_tree to fallback to mdls if needed * Fixed image_file_utils for non-Spotlight volumes * Fixed image_file_utils for non-Spotlight volumes * Removed unneeded imports * Tests passing for renamed edited photos * Initial tests for import CLI utils * Initial tests for import CLI utils * Fixed regex for finding original / edited images * Typo (my bad!) on GoPro Pics filename standards. (#1551) * Added test images for import tests * Fix for edited live photos * Fixed skip if not macOS * Added test for edited live photo * Added clarification for --resume, --skip-dups, #802 * Fix for certain edited live photos * Reset counter * Added --exportdir * Fixed help formatting --------- Co-authored-by: oPromessa <mario@silvapereira.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.